Open
Conversation
nancy-harris
left a comment
There was a problem hiding this comment.
It looks like you have two copies of every CSS file. It would be good to keep the repo clean by removing unused files.
Personal Portfolio Site
What We're Looking For
| Feature | Feedback |
|---|---|
| Baseline | |
| Appropriate Git Usage | ✅ |
| Answered comprehension questions | ✅ |
| Page fully loads | ✅ |
| No broken links (regular or images) | ✅ Mostly |
| Includes at least 3 pages and styling | ✅ |
| HTML | |
Uses the high-level tags for organization: header, footer, main |
✅ |
Appropriately using semantic tags: section, article, etc. |
✅ |
| All images include alternate text | ✅ |
| CSS | |
| Using class and ID names in style declarations | ✅ |
| Style declarations are DRY | Mostly |
| Uses Flexbox and/or Grid | ✅ |
| Overall | ✅ |
| Coming from a background in operations, Tara utilizes data to drive solutions that meet needs while supporting healthy work culture for all. | ||
| All that has changed is the language (or, languages) used to reach those solutions. </p> | ||
| <br> | ||
| <img src="../images/computer image.jpeg" alt="old-school computer graphic"> |
There was a problem hiding this comment.
Image URLs should not have a space in them, it causes errors. Make sure when you add assets and name them to remove spaces!
| text-decoration: none; | ||
| } | ||
|
|
||
| a:active { |
There was a problem hiding this comment.
Since this property here is the same as the one for a:link, you can do:
a:link, a:active {
text-decoration: none;
}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Personal Portfolio Site
Congratulations! You're submitting your assignment!
Comprehension Questions