Skip to content

Amethyst-C19-Kaliane-Van-JS-Adagrams#55

Open
MotifNoticer wants to merge 2 commits intoAdaGold:mainfrom
MotifNoticer:main
Open

Amethyst-C19-Kaliane-Van-JS-Adagrams#55
MotifNoticer wants to merge 2 commits intoAdaGold:mainfrom
MotifNoticer:main

Conversation

@MotifNoticer
Copy link

No description provided.

Comment on lines 2 to +9
export const drawLetters = () => {
// Implement this method for wave 1
const letterPool = {
'A': 9, 'B': 2, 'C': 2, 'D': 4, 'E': 12,'F': 2,
'G': 3, 'H': 2, 'I': 9, 'J': 1, 'K': 1, 'L': 4,
'M': 2, 'N': 6, 'O': 8, 'P': 2, 'Q': 1, 'R': 6,
'S': 4, 'T': 6, 'U': 4, 'V': 2, 'W': 2, 'X': 1,
'Y': 2, 'Z': 1
};

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Kaliane! Great job completing JS Adagrams! Congrats on finishing your first JavaScript project 🎉 Excellent choice with this data structure, I just want to mention that in JavaScript our keys don't need to be strings. Because of the popularity of JSON, it is frequent to see the keys of object literals as quoted strings. The quotes are required in order to be valid JSON, but they are not required in order to be valid JavaScript. Keys in object literals can be expressed in any of the following three ways:

const letterValue = {  
  A: 9,      // No quotes at all  
  'A': 9,    // Single-quoted string  
  "A": 9  // Double-quoted string
};

Comment on lines +11 to +20
let letters = [];
for (let letter in letterPool) {
for (let i = 0; i < letterPool[letter]; i++) {
letters.push(letter);
}
}

let hand = [];
for (let i = 0; i < 10; i++) {
let randomIndex = Math.floor(Math.random() * letters.length);

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work getting comfortable with JavaScript's syntax. It looks like you're getting use to looping over data and adding conditional logic ✅

Comment on lines 29 to +37
export const usesAvailableLetters = (input, lettersInHand) => {
// Implement this method for wave 2
let lettersInHandCopy = [...lettersInHand];
for (let letter of input) {
if (!lettersInHandCopy.includes(letter)) {
return false;
} else {
let index = lettersInHandCopy.indexOf(letter);
lettersInHandCopy.splice(index, 1);
}

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work!

Comment on lines +59 to +68
let score = 0;

for (let letter of word.toUpperCase()) {
score += letterScores[letter];
}

if (word.length >= 7) {
score += 8;
}

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice job translating this logic 👍🏾

Comment on lines +81 to +89
if (score > highestScore) {
highestScore = score;
highestScoringWord = word;
} else if (score === highestScore) {
if (word.length === 10 && highestScoringWord.length !== 10) {
highestScoringWord = word;
} else if (word.length < highestScoringWord.length && highestScoringWord.length !== 10) {
highestScoringWord = word;
}

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work with these variable names!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants