-
Notifications
You must be signed in to change notification settings - Fork 13
Context hpc datasets #275
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Samuel-WM
wants to merge
19
commits into
AdaptInfer:tasksplit_hpc
Choose a base branch
from
Samuel-WM:context-hpc-datasets
base: tasksplit_hpc
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Context hpc datasets #275
Samuel-WM
wants to merge
19
commits into
AdaptInfer:tasksplit_hpc
from
Samuel-WM:context-hpc-datasets
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
See if you can get the tests to run. If not, move to a branch on the repo instead of your fork. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the initial end-to-end HPC/DDP implementation for the sklearn-style interface.
Before opening the PR, I ran scaling-oriented validation on the new distributed path to confirm the training loop was stable under multi-rank execution and that performance characteristics (epoch time / throughput / step time) behaved as expected as world size increased. Those checks focused on fit and predict workloads and included basic correctness signals.
After those initial runs, I discovered an implementation mistake introduced during subsequent development on the DDP prediction/aggregation. The reason this was not obvious from the earlier scaling results is that DDP training stability and scaling can look correct even when the predict path is missing the required cross-rank aggregation details (synchronizing outputs, restoring global row ordering, and deduplicating sampler padding). I have made the necessary corrections in this branch, and am redoing the benchmark and perturbation tests with the updated package.