Drop adde-lint, use sass-lint + prettier for "lint:sass" run script#1164
Merged
Drop adde-lint, use sass-lint + prettier for "lint:sass" run script#1164
Conversation
This was referenced Feb 6, 2025
mixonic
approved these changes
Feb 6, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to #1163.
This drops the
adde-lint --sassin favor of using the underlying commands directly.The adde-lint subcommand (defined here) runs both sass-lint and prettier:
https://github.com/Addepar/addepar-ember-toolbox/blob/897b838c696c422bdf70c81983e6ecc29db2e34b/lib/lint.js#L163-L166
which in turn are defined at:
https://github.com/Addepar/addepar-ember-toolbox/blob/897b838c696c422bdf70c81983e6ecc29db2e34b/lib/lint.js#L115-L140
I added a log line at https://github.com/Addepar/addepar-ember-toolbox/blob/897b838c696c422bdf70c81983e6ecc29db2e34b/lib/lint.js#L22 to double-check the exact commands that are run.
A few minor changes:
--verbose --no-exitinstead of-vqfor sass-lint,--list-filesfor prettier)--configflagThe glob paths passed to prettier are the same ones that
adde-lintwould -- it checks for presence of certain paths on disk and concats all the dirs it finds. I've left it the same for future-proofing, although there are no scss files inaddon/.Notes:
.cssfiles in this repo; they are not linted (via sass-lint or prettier). This PR doesn't change that