Skip to content

fix(dns64): CNAME/DNAME should not be treated as hasAnswer #439

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
L2jLiga wants to merge 2 commits into
base: master
Choose a base branch
from
Open

fix(dns64): CNAME/DNAME should not be treated as hasAnswer #439

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
bb330a2
fix(dns64): CNAME/DNAME should not be treated as hasAnswer
L2jLiga Feb 23, 2025
5e68941
Merge branch 'AdguardTeam:master' into fix/dns64-cname-dname
L2jLiga Jul 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 0 additions & 9 deletions proxy/dns64.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -129,15 +129,6 @@ func (p *Proxy) filterNAT64Answers(rrs []dns.RR) (filtered []dns.RR, hasAnswers
} else {
filtered, hasAnswers = append(filtered, ans), true
}
case *dns.CNAME, *dns.DNAME:
// If the response contains a CNAME or a DNAME, then the CNAME or
// DNAME chain is followed until the first terminating A or AAAA
// record is reached.
//
// Just treat CNAME and DNAME responses as passable answers since
// AdGuard Home doesn't follow any of these chains except the
// dnsrewrite-defined ones.
filtered, hasAnswers = append(filtered, ans), true
default:
filtered = append(filtered, ans)
}
Expand Down