handler, cmd: add disable-ipv4 option #470
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![windsurf-bot[bot]](https://avatars.githubusercontent.com/in/1066231?s=60&v=4){kind=small}
| // haltA halts the processing of A requests if IPv4 is disabled. req must | ||
| // not be nil. | ||
| func (h *Default) haltA(ctx context.Context, req *dns.Msg) (resp *dns.Msg) { | ||
| if h.isIPv4Halted && req.Question[0].Qtype == dns.TypeA { |
There was a problem hiding this comment.
This code could panic if req.Question is empty. Consider adding a check to ensure len(req.Question) > 0 before accessing req.Question[0].
There was a problem hiding this comment.
Shouldn't be a problem, as semantically, queries have a question, and in fact the existing IPv6-specific code (which I copy-pasted from) also doesn't include a check.
The new disable-ipv4 option operates completely analogously to the existing disable-ipv6 option: A records are discarded from answers. This feature is useful on IPv6-only hosts with misbehaving applications that only attempt one connection using the first DNS answer.
mikitsu
force-pushed
the
add-disable-ipv4-option
branch
from
fc6c04c to
5b00a12
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new disable-ipv4 option operates completely analogously to the existing disable-ipv6 option: A records are discarded from answers.
This feature is useful on IPv6-only hosts with misbehaving applications that only attempt one connection using the first DNS answer.