Skip to content

Conversation

juan-aristide
Copy link

Item level text overlaps with upgrade indicator.

Item level text overlaps with upgrade indicator.
@Talyrius
Copy link
Contributor

Are you seeing the errors discussed in #174?

@juan-aristide
Copy link
Author

juan-aristide commented Mar 31, 2017

Just checked and im getting the error when opening bank UI.
Can i help you in any way?

@Talyrius
Copy link
Contributor

Talyrius commented Apr 1, 2017

I'd like to hear some more opinions on this change. Can you share a before and after screenshot?

@legowxelab2z8
Copy link
Contributor

The current position of item level text overlaps the UpgradeIcon
upgrade icon topleft

With this change the item level is in the bottom left
itemlevel bottomleft

I played around with some options and moved the upgrade icon to the topright. This required shifting the item level to the left to make room. I like the look of this option the best and it retains a similar placement of the item level text.
upgrade icon topright

@juan-aristide
Copy link
Author

Nice Lego! I like arrow and ilvl in the same line. But i think it will not work with all the fonts (not at home to test). And what happens if we get ilvl 1000 anytime soon?

@legowxelab2z8
Copy link
Contributor

The item level text uses NumberFontNormal and isn't user configurable. NumberFontNormal inherits from NumberFont_Outline_Med which looks like it might render as a different width for simplifiedchinese and traditionalchinese.

4 digit item levels will overlap with the upgrade icon. There doesn't seem to be enough room to fit both item level and the upgrade icon on the same line when item levels reach 1000.
4 digit item level

@Trid3nt1
Copy link

Trid3nt1 commented Apr 1, 2017

The layout looks crisp with the adjusted text location. I think the image with the arrow-icon to the right looks more fluent, as it shows ilvl first and foremost - Followed by an arrow indicating if it is in-fact an upgrade.

@onyxraven
Copy link

I like the item level on the bottom left, if we're thinking ilvl 1000 is coming in WoW.8

@Talyrius
Copy link
Contributor

Closed in favor of #496.

@Talyrius Talyrius closed this Oct 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants