This solves the flipping on y axis, I think there is no need for _get_dv_extent_um#1
Open
RobertoDF wants to merge 1 commit intoAdityaGupta716:fix/streamlines-urlfrom
Open
This solves the flipping on y axis, I think there is no need for _get_dv_extent_um#1RobertoDF wants to merge 1 commit intoAdityaGupta716:fix/streamlines-urlfrom
RobertoDF wants to merge 1 commit intoAdityaGupta716:fix/streamlines-urlfrom
Conversation
Removed unused function and parameters related to dorsal-ventral extent caching. Updated related functions to eliminate dependency on DV extent.
Author
Owner
|
Thanks @RobertoDF you were correct, no flips needed, I've incorporated this into the main PR (brainglobe#438) rather than merging this directly because: There's a small syntax error (y = float voxel["max_voxel_y"]) missing opening paren) and |
Owner
|
@RobertoDF and also do check out the changes i made in the PR and review it !Thanks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removed unused function and parameters related to dorsal-ventral extent caching. Updated related functions to eliminate dependency on DV extent.