Evaluate each substream when sorting a list of lazy streams#199
Open
monkeygroover wants to merge 1 commit intoAdriandmen:masterfrom
Open
Evaluate each substream when sorting a list of lazy streams#199monkeygroover wants to merge 1 commit intoAdriandmen:masterfrom
monkeygroover wants to merge 1 commit intoAdriandmen:masterfrom
Conversation
Draft
- before sorting we need to actually resolve each of the inner functions so the sort applies to the result not the lazy stream fn - fixes Adriandmen#184
monkeygroover
force-pushed
the
fix-184
branch
from
0f9318b to
2167786
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
before sorting we need to actually resolve each of the inner functions so the sort applies to the result not the lazy stream fn
fixes Sorting indexed list doesn't work #184