Conversation
Summary of ChangesHello @gcatanese, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request significantly enhances the Transfers API and its associated webhooks by introducing new data fields and expanding existing enumerations. These updates aim to provide more granular detail for financial transactions, including new bank identification types, improved tracking for transfer statuses, and the ability to specify 3D Secure information. The changes also include new models for execution dates and funding instruments, alongside better API query options, ultimately improving the flexibility and informational richness of the transfer system. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request introduces several updates across both Transfer Webhooks and Transfers API models and services. Key changes include reordering and updating enum members in AdditionalBankIdentification (which is a breaking change due to altered integer values), refining documentation for Amount and BankCategoryData descriptions, and correcting a link in BalancePlatformNotificationResponse. New fields like storedPaymentMethodId have been added to BankAccountV3, email and url to PartyIdentification, and threeDSecure to IssuedCard. A new ExecutionDate model has been introduced, and HKLocalAccountIdentification now supports longer account numbers. The ConfirmationTrackingData and InternalReviewTrackingData models have updated status descriptions, with ConfirmationTrackingData adding an 'accepted' status. The PlatformPayment model received more detailed descriptions for its payment types. TransferData and Transfer models now include createdAt, executionDate, and updatedAt fields, with creationDate being deprecated, and new reasons (ApprovalExpired, SchemeAdvice) added to their ReasonEnum. The TransactionsService and TransfersService interfaces have been updated to include a sortOrder parameter in their GetAllTransactions and GetAllTransfers methods, respectively, which is noted as a breaking change for implementers. Additionally, FundingInstrument and ThreeDSecure models were added to the Transfers API, and UltimatePartyIdentification now includes email, url, and fundingInstrument fields.
Generate Transfers API and webhooks code
🛠 Breaking Changes
Transfers API
AdditionalBankIdentification.cstheTypeEnumenums order has changed: the string value is still the same, but the underlying numeric index has changedTransfer Webhooks
AdditionalBankIdentification.cstheTypeEnumenums order has changed: the string value is still the same, but the underlying numeric index has changedNew Features
Transfers API
TransactionsServiceadd optional attributesortOrdertoGetAllTransactionsmethodTransfersServiceadd optional attributesortOrdertoGetAllTransfersmethodBankAccountV3addstoredPaymentMethodIdattributeConfirmationTrackingDataadd enumacceptedIssuedCardadd attributethreeDSecurePartyIdentificationaddemailandurlattributesTransferadd enumsapprovalExpiredandschemeAdviceTransferadd attributescreatedAt,executionDateTransferDataadd enumsapprovalExpiredandschemeAdviceTransferDataadd attributescreatedAt,executionDate,updatedAtTransferEventadd enumsapprovalExpiredandschemeAdviceTransferInfoadd attributeexecutionDateUltimatePartyIdentificationadd attributesfundingInstrument, emailandurl`Transfer Webhooks
BankAccountV3add attributestoredPaymentMethodIdConfirmationTrackingDataadd enumacceptedIssuedCardadd attributethreeDSecurePartyIdentificationadd attributesemailandurlTransferDataadd enumsapprovalExpiredandschemeAdviceTransferDataadd attributescreatedAt,executionDate,updatedAtTransferEventadd enumsapprovalExpiredandschemeAdvice