Balance Platform: generate models and services#1223
Conversation
Summary of ChangesHello @gcatanese, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request integrates significant updates to the Adyen Balance Platform API client, primarily focusing on expanding its capabilities for managing financial instruments and associated controls. The changes introduce new services and models for handling authorized card users, network token provisioning, and transfer limits, alongside general enhancements to existing data structures and their documentation. The update ensures the client remains aligned with the latest Balance Platform API specifications. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
The pull request introduces new API functionalities and corresponding test cases for Balance Platform services, including network token provisioning, authorized card users management, and transfer limits at both balance account and platform levels. It also updates several model definitions, adding new fields, clarifying existing documentation, and modifying enum structures. Specifically, new enum members were added to AdditionalBankIdentification.TypeEnum, BankIdentification.IdentificationTypeEnum, and CreateSweepConfigurationV2.ReasonEnum, which resulted in renumbering existing enum values. The review comments highlight these enum renumbering changes as high-risk breaking changes, advising against modifying existing integer values for backward compatibility and instead suggesting appending new members to the end of the enum list.
Balance Platform: generate models and services
BalancePlatform API
AuthorizedCardUsersServiceto manage (add, get, delete and update) authorized users to a given cardTransferLimitsBalanceAccountLevelApito support Transfer limits - balance account level`TransferLimitsBalancePlatformLevelApito manageTransfer limits - balance platform levelAccountHoldersService. GetTaxFormadd optional parameterlegalEntityIdTransferRouteRequirementsextends the support to addAdditionalBankIdentificationRequirement, USInstantPayoutAddressRequirement,USInternationalAchPriorityRequirement`AuBsbCodeandCaRoutingNumberinAdditionalBankIdentificationBictoBankIdentificationBulkAddressadd attributesName,Line1,Line2,Line3usagetoCardandCardInfoto specify how many times the card can be used: singleUse or multiUse.ApprovalExpired,Pending,SchemeAdvicetoCreateSweepConfigurationV2,UpdateSweepConfigurationV2andSweepConfigurationV2ReplacedByIdandReplacementOfIdinPaymentInstrument,UpdatePaymentInstrumentWalletProviderAccountScore,WalletProviderDeviceScore,WalletProviderDeviceTypeinTransactionRuleRestrictionsInterestinTransferRouteDataReviewSeveral attributes (
cardCaptureTechnology,deviceName,imei,isoDeviceType,msisdn,osVersion,paymentTypes,serialNumber,storageTechnology) have been removedDeviceInfo: this is NOT considered a breaking change since those attributes were never included in the API responseBalancePlatform Webhooks
BulkAddressadd attributesName,Line1,Line2,Line3usagetoCardDeviceIdinDeviceSchemeRiskScoreandTransactionRulesResultinNetworkTokenNotificationDataV2ApprovalExpired,SchemeAdvicetoSweepConfigurationV2`