Conversation
|
Warning You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again! |
jeandersonbc
approved these changes
Feb 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces comprehensive unit tests for the SCA Association Management functionality in the Balance Platform, adds new mock JSON files for test data, and expands test coverage for custom headers in both the Payments and Terminal API services. The changes ensure that serialization/deserialization of requests and responses is validated, custom header handling is thoroughly tested, and the test suite is better organized with realistic mock data.
SCA Association Management Test Coverage:
SCAAssociationManagementTestwith tests for deserializingApproveAssociationRequest,ApproveAssociationResponse,ListAssociationsResponse, andRemoveAssociationRequestusing new mock JSON files. This validates that the models correctly map to the expected API payloads. [1] [2] [3] [4] [5]SCAAssociationManagementServiceTestto verify that the service sends requests with the correct headers, properly handles unauthorized responses, and checks that the service methods are called with expected arguments.Mock Data Additions:
Custom Header Handling Tests:
PaymentsTestto verify that additional custom headers are correctly added and sent with the Payments service requests.HeaderRequestTestto ensure that additional custom headers can be added toRequestOptionsand are stored as expected.Minor Code Cleanup:
HeaderRequestTest.csfor better maintainability.DescriptionTested scenarios
Fixed issue: