feat(tls): allow disabling protocol upgrade #1409
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Thank you very much @sp00m for your contribution. It looks like a valid solution. I'd add a one-line comment to explain the purpose of |
Contributor
Author
Done, feel free to update. |
DjoykeAbyah
added a commit
that referenced
this pull request
Dec 30, 2024
This reverts commit edc79d8.
DjoykeAbyah
added a commit
that referenced
this pull request
Dec 30, 2024
Merged
sp00m
added a commit
to sp00m/adyen-java-api-library
that referenced
this pull request
Feb 3, 2025
…)" (Adyen#1414)" This reverts commit cc52b02.
gcatanese
pushed a commit
that referenced
this pull request
Feb 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since version v29.1.0 of your SDK, you're relying on Apache HttpClient v5.4 (diff).
This version of HttpClient doesn't play well with Istio: istio/istio#53239
A way to fix this is to disable the protocol upgrade, which HttpClient allows. This is what this PRs proposes.
It's also the recommended approach by Spring Boot: spring-projects/spring-boot#43139 (while waiting for envoyproxy/envoy#36305).