[posmobile] Code generation: update services and models #1629

AdyenAutomationBot · 2026-01-05T15:20:03Z

This PR contains the automated changes for the posmobile service.

The commit history of this PR reflects the adyen-openapi commits that have been applied.

gemini-code-assist · 2026-01-05T15:20:24Z

Summary of Changes

Hello @AdyenAutomationBot, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request delivers an automated update to the posmobile service, incorporating the latest specifications from adyen-openapi. The modifications are largely focused on code hygiene, including formatting, Javadoc standardization, and import organization, ensuring the generated code remains consistent and easy to maintain without introducing any functional changes.

Highlights

Automated Code Generation Update: This pull request is an automated update to the posmobile service, reflecting recent changes from the adyen-openapi specification.
Code Formatting and Readability: Numerous minor formatting adjustments have been applied across several model and service files, including consistent indentation, newline usage, and reordering of imports, enhancing overall code readability.
Javadoc and Comment Refinements: Javadoc comments have been standardized and slightly rephrased for clarity in AbstractOpenApiSchema.java, CreateSessionRequest.java, and CreateSessionResponse.java.
No Functional Changes: The changes are primarily cosmetic and structural, with no new features introduced or existing business logic altered in the posmobile service or its associated models.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	`/gemini review`	Performs a code review for the current pull request in its current state.
Pull Request Summary	`/gemini summary`	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	`/gemini help`	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

gemini-code-assist

Code Review

This pull request introduces a series of automated code generation changes. While many of these changes improve code style, such as standardizing indentation to 4 spaces, there are several issues introduced across multiple files. These include high-severity issues like empty statements in equals methods, which are confusing and suggest a bug in the code generator. Additionally, there are numerous formatting problems in Javadocs, such as malformed comment blocks, extremely long lines that hurt readability, and inconsistent method body styling. These issues suggest problems with the code generation templates or configuration that should be addressed to ensure the generated code is correct and maintainable.

gemini-code-assist · 2026-01-05T15:23:16Z

src/main/java/com/adyen/model/posmobile/CreateSessionRequest.java

+        Objects.equals(this.isSetSetupToken, createSessionRequest.isSetSetupToken) &&
+        Objects.equals(this.store, createSessionRequest.store) &&
+        Objects.equals(this.isSetStore, createSessionRequest.isSetStore)
+    ;


This empty statement is unnecessary and confusing. It appears to be a code generation artifact and should be removed. While it doesn't cause a compilation error, it makes the code harder to understand.

gemini-code-assist · 2026-01-05T15:23:17Z

src/main/java/com/adyen/model/posmobile/CreateSessionResponse.java

+        Objects.equals(this.isSetSdkData, createSessionResponse.isSetSdkData) &&
+        Objects.equals(this.store, createSessionResponse.store) &&
+        Objects.equals(this.isSetStore, createSessionResponse.isSetStore)
+    ;


This empty statement is unnecessary and confusing. It appears to be a code generation artifact and should be removed. While it doesn't cause a compilation error, it makes the code harder to understand.

gemini-code-assist · 2026-01-05T15:23:17Z

src/main/java/com/adyen/model/posmobile/CreateSessionResponse.java

-   * API](https://docs.adyen.com/point-of-sale/design-your-integration/terminal-api/) transaction
-   * request on your backend, use this as the &#x60;POIID&#x60; in the &#x60;MessageHeader&#x60; of
-   * the request.
+   * The unique identifier of the SDK installation. If you create the [Terminal API](https://docs.adyen.com/point-of-sale/design-your-integration/terminal-api/) transaction request on your backend, use this as the &#x60;POIID&#x60; in the &#x60;MessageHeader&#x60; of the request.


This Javadoc line is very long and harms readability. It should be wrapped to fit within a reasonable line length limit (e.g., 100-120 characters). The previous multi-line format was more readable.

gemini-code-assist · 2026-01-05T15:23:17Z

src/main/java/com/adyen/model/posmobile/AbstractOpenApiSchema.java

+     * @return an instance of the actual schema/object
+     */
+    @JsonValue
+    public Object getActualInstance() {return instance;}


For consistency and readability, it's better to place the method body on a new line, even for single-line methods. This is a common practice in Java style guides.

public Object getActualInstance() { return instance; }

gemini-code-assist · 2026-01-05T15:23:17Z

src/main/java/com/adyen/model/posmobile/CreateSessionRequest.java

-   * &#x60;AuthenticationService&#x60;. - When using the iOS POS Mobile SDK, obtain the token
-   * through the &#x60;PaymentServiceDelegate.register(with:)&#x60; callback of
-   * &#x60;PaymentServiceDelegate&#x60;.
+   * The setup token provided by the POS Mobile SDK.  - When using the Android POS Mobile SDK, obtain the token through the &#x60;AuthenticationService.authenticate(setupToken)&#x60; callback of &#x60;AuthenticationService&#x60;.  - When using the iOS POS Mobile SDK, obtain the token through the &#x60;PaymentServiceDelegate.register(with:)&#x60; callback of &#x60;PaymentServiceDelegate&#x60;.


This Javadoc line is very long and harms readability. It should be wrapped to fit within a reasonable line length limit (e.g., 100-120 characters). The previous multi-line format was more readable.

gemini-code-assist · 2026-01-05T15:23:17Z

src/main/java/com/adyen/model/posmobile/JSON.java

-  public static ObjectMapper getMapper() {
-    return mapper;
-  }
+  public static ObjectMapper getMapper() { return mapper; }


For consistency and readability, it's better to place the method body on a new line, even for single-line methods. This is a common practice in Java style guides.

public static ObjectMapper getMapper() { return mapper; }

gemini-code-assist · 2026-01-05T15:23:17Z

src/main/java/com/adyen/model/posmobile/JSON.java

+  static
+  {


The formatting of this static block is unconventional. Standard Java formatting places the opening brace on the same line as the static keyword (static {) or on the next line, but not with static and { on separate lines.

static {

gemini-code-assist · 2026-01-05T15:23:17Z

src/main/java/com/adyen/service/posmobile/PosMobileApi.java

+    /**
+    * Create a communication session
+    *
+    * @param createSessionRequest {@link CreateSessionRequest }  (required)


The Javadoc has extra spaces around the {@link} tag. These should be removed for cleaner formatting.

Suggested change

* @param createSessionRequest {@link CreateSessionRequest } (required)

* @param createSessionRequest {@link CreateSessionRequest} (required)

gemini-code-assist · 2026-01-05T15:23:17Z

src/main/java/com/adyen/service/posmobile/PosMobileApi.java

+    * Create a communication session
+    *
+    * @param createSessionRequest {@link CreateSessionRequest }  (required)
+    


This blank line in the Javadoc is unnecessary and should be removed.

gemini-code-assist · 2026-01-05T15:23:17Z

src/main/java/com/adyen/service/posmobile/PosMobileApi.java

+    /**
+    * Create a communication session
+    *
+    * @param createSessionRequest {@link CreateSessionRequest }  (required)


The Javadoc has extra spaces around the {@link} tag. These should be removed for cleaner formatting.

Suggested change

* @param createSessionRequest {@link CreateSessionRequest } (required)

* @param createSessionRequest {@link CreateSessionRequest} (required)

AdyenAutomationBot requested review from a team as code owners January 5, 2026 15:20

gemini-code-assist bot reviewed Jan 5, 2026

View reviewed changes

AdyenAutomationBot force-pushed the sdk-automation/posmobile branch 3 times, most recently from 9e2ed98 to 95be244 Compare January 8, 2026 12:04

[posmobile] Automated update from Adyen/adyen-openapi@0a007ce

bffcbfc

AdyenAutomationBot force-pushed the sdk-automation/posmobile branch from 7d1b0a3 to bffcbfc Compare January 8, 2026 14:34

style(fmt): code formatted

9035f27

	* @param createSessionRequest {@link CreateSessionRequest } (required)
	* @param createSessionRequest {@link CreateSessionRequest} (required)

[posmobile] Code generation: update services and models #1629

Are you sure you want to change the base?

[posmobile] Code generation: update services and models #1629

Uh oh!

Conversation

AdyenAutomationBot commented Jan 5, 2026

Uh oh!

gemini-code-assist bot commented Jan 5, 2026

Summary of Changes

Highlights

Footnotes

Uh oh!

gemini-code-assist bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

gemini-code-assist bot Jan 5, 2026

Choose a reason for hiding this comment

Uh oh!

gemini-code-assist bot Jan 5, 2026

Choose a reason for hiding this comment

Uh oh!

gemini-code-assist bot Jan 5, 2026

Choose a reason for hiding this comment

Uh oh!

gemini-code-assist bot Jan 5, 2026

Choose a reason for hiding this comment

Uh oh!

gemini-code-assist bot Jan 5, 2026

Choose a reason for hiding this comment

Uh oh!

gemini-code-assist bot Jan 5, 2026

Choose a reason for hiding this comment

Uh oh!

gemini-code-assist bot Jan 5, 2026

Choose a reason for hiding this comment

Uh oh!

gemini-code-assist bot Jan 5, 2026

Choose a reason for hiding this comment

Uh oh!

gemini-code-assist bot Jan 5, 2026

Choose a reason for hiding this comment

Uh oh!

gemini-code-assist bot Jan 5, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants