-
Notifications
You must be signed in to change notification settings - Fork 144
[tokenizationwebhooks] Code generation: update services and models #1630
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Summary of ChangesHello @AdyenAutomationBot, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request delivers an automated update to the Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request contains automated changes from a code generator, primarily focused on updating services and models for tokenizationwebhooks. The changes are mostly stylistic, including adjustments to indentation, Javadoc formatting, import ordering, and newlines. I've reviewed the changes and found one minor point of improvement for code consistency in JSON.java. Otherwise, the changes look good and don't introduce any functional issues.
| /** | ||
| * A map of discriminators for all model classes. | ||
| */ | ||
| private static final Map<Class<?>, ClassDiscriminatorMapping> modelDiscriminators = new HashMap<Class<?>, ClassDiscriminatorMapping>(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For consistency and improved readability, it's better to use the diamond operator <> for type inference, which is available since Java 7. This is already used for modelDescendants in this same file.
| private static final Map<Class<?>, ClassDiscriminatorMapping> modelDiscriminators = new HashMap<Class<?>, ClassDiscriminatorMapping>(); | |
| private static final Map<Class<?>, ClassDiscriminatorMapping> modelDiscriminators = new HashMap<>(); |
7958c2b to
6780edf
Compare
9cb4d4d to
7725ff1
Compare
This PR contains the automated changes for the
tokenizationwebhooksservice.The commit history of this PR reflects the
adyen-openapicommits that have been applied.