-
Notifications
You must be signed in to change notification settings - Fork 144
[paymentsapp] Code generation: update services and models #1631
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Summary of ChangesHello @AdyenAutomationBot, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request delivers an automated update to the Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request updates auto-generated services and models for the paymentsapp. The changes primarily consist of formatting adjustments, such as indentation and Javadoc updates. However, the code generation process has introduced a couple of consistent styling issues. Several model classes now have a strange trailing semicolon in their equals methods, which should be corrected. Additionally, the PaymentsAppApi class has extra blank lines within method signatures, impacting readability. I've left specific comments on these issues. It would be beneficial to fix the underlying code generation templates to prevent these issues in future updates.
| return Objects.equals(this.boardingRequestToken, boardingTokenRequest.boardingRequestToken) && | ||
| Objects.equals(this.isSetBoardingRequestToken, boardingTokenRequest.isSetBoardingRequestToken) | ||
| ; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The equals method has a trailing semicolon on a new line, which is unconventional and harms code readability. Please move the semicolon to the end of the return statement on the previous line.
| return Objects.equals(this.boardingRequestToken, boardingTokenRequest.boardingRequestToken) && | |
| Objects.equals(this.isSetBoardingRequestToken, boardingTokenRequest.isSetBoardingRequestToken) | |
| ; | |
| return Objects.equals(this.boardingRequestToken, boardingTokenRequest.boardingRequestToken) && | |
| Objects.equals(this.isSetBoardingRequestToken, boardingTokenRequest.isSetBoardingRequestToken); |
| return Objects.equals(this.boardingToken, boardingTokenResponse.boardingToken) && | ||
| Objects.equals(this.isSetBoardingToken, boardingTokenResponse.isSetBoardingToken) && | ||
| Objects.equals(this.installationId, boardingTokenResponse.installationId) && | ||
| Objects.equals(this.isSetInstallationId, boardingTokenResponse.isSetInstallationId) | ||
| ; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The equals method has a trailing semicolon on a new line, which is unconventional and harms code readability. Please move the semicolon to the end of the return statement on the previous line.
| return Objects.equals(this.boardingToken, boardingTokenResponse.boardingToken) && | |
| Objects.equals(this.isSetBoardingToken, boardingTokenResponse.isSetBoardingToken) && | |
| Objects.equals(this.installationId, boardingTokenResponse.installationId) && | |
| Objects.equals(this.isSetInstallationId, boardingTokenResponse.isSetInstallationId) | |
| ; | |
| return Objects.equals(this.boardingToken, boardingTokenResponse.boardingToken) && | |
| Objects.equals(this.isSetBoardingToken, boardingTokenResponse.isSetBoardingToken) && | |
| Objects.equals(this.installationId, boardingTokenResponse.installationId) && | |
| Objects.equals(this.isSetInstallationId, boardingTokenResponse.isSetInstallationId); |
| return Objects.equals(this.detail, defaultErrorResponseEntity.detail) && | ||
| Objects.equals(this.isSetDetail, defaultErrorResponseEntity.isSetDetail) && | ||
| Objects.equals(this.errorCode, defaultErrorResponseEntity.errorCode) && | ||
| Objects.equals(this.isSetErrorCode, defaultErrorResponseEntity.isSetErrorCode) && | ||
| Objects.equals(this.instance, defaultErrorResponseEntity.instance) && | ||
| Objects.equals(this.isSetInstance, defaultErrorResponseEntity.isSetInstance) && | ||
| Objects.equals(this.invalidFields, defaultErrorResponseEntity.invalidFields) && | ||
| Objects.equals(this.isSetInvalidFields, defaultErrorResponseEntity.isSetInvalidFields) && | ||
| Objects.equals(this.requestId, defaultErrorResponseEntity.requestId) && | ||
| Objects.equals(this.isSetRequestId, defaultErrorResponseEntity.isSetRequestId) && | ||
| Objects.equals(this.status, defaultErrorResponseEntity.status) && | ||
| Objects.equals(this.isSetStatus, defaultErrorResponseEntity.isSetStatus) && | ||
| Objects.equals(this.title, defaultErrorResponseEntity.title) && | ||
| Objects.equals(this.isSetTitle, defaultErrorResponseEntity.isSetTitle) && | ||
| Objects.equals(this.type, defaultErrorResponseEntity.type) && | ||
| Objects.equals(this.isSetType, defaultErrorResponseEntity.isSetType) | ||
| ; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The equals method has a trailing semicolon on a new line, which is unconventional and harms code readability. Please move the semicolon to the end of the return statement on the previous line.
| return Objects.equals(this.detail, defaultErrorResponseEntity.detail) && | |
| Objects.equals(this.isSetDetail, defaultErrorResponseEntity.isSetDetail) && | |
| Objects.equals(this.errorCode, defaultErrorResponseEntity.errorCode) && | |
| Objects.equals(this.isSetErrorCode, defaultErrorResponseEntity.isSetErrorCode) && | |
| Objects.equals(this.instance, defaultErrorResponseEntity.instance) && | |
| Objects.equals(this.isSetInstance, defaultErrorResponseEntity.isSetInstance) && | |
| Objects.equals(this.invalidFields, defaultErrorResponseEntity.invalidFields) && | |
| Objects.equals(this.isSetInvalidFields, defaultErrorResponseEntity.isSetInvalidFields) && | |
| Objects.equals(this.requestId, defaultErrorResponseEntity.requestId) && | |
| Objects.equals(this.isSetRequestId, defaultErrorResponseEntity.isSetRequestId) && | |
| Objects.equals(this.status, defaultErrorResponseEntity.status) && | |
| Objects.equals(this.isSetStatus, defaultErrorResponseEntity.isSetStatus) && | |
| Objects.equals(this.title, defaultErrorResponseEntity.title) && | |
| Objects.equals(this.isSetTitle, defaultErrorResponseEntity.isSetTitle) && | |
| Objects.equals(this.type, defaultErrorResponseEntity.type) && | |
| Objects.equals(this.isSetType, defaultErrorResponseEntity.isSetType) | |
| ; | |
| return Objects.equals(this.detail, defaultErrorResponseEntity.detail) && | |
| Objects.equals(this.isSetDetail, defaultErrorResponseEntity.isSetDetail) && | |
| Objects.equals(this.errorCode, defaultErrorResponseEntity.errorCode) && | |
| Objects.equals(this.isSetErrorCode, defaultErrorResponseEntity.isSetErrorCode) && | |
| Objects.equals(this.instance, defaultErrorResponseEntity.instance) && | |
| Objects.equals(this.isSetInstance, defaultErrorResponseEntity.isSetInstance) && | |
| Objects.equals(this.invalidFields, defaultErrorResponseEntity.invalidFields) && | |
| Objects.equals(this.isSetInvalidFields, defaultErrorResponseEntity.isSetInvalidFields) && | |
| Objects.equals(this.requestId, defaultErrorResponseEntity.requestId) && | |
| Objects.equals(this.isSetRequestId, defaultErrorResponseEntity.isSetRequestId) && | |
| Objects.equals(this.status, defaultErrorResponseEntity.status) && | |
| Objects.equals(this.isSetStatus, defaultErrorResponseEntity.isSetStatus) && | |
| Objects.equals(this.title, defaultErrorResponseEntity.title) && | |
| Objects.equals(this.isSetTitle, defaultErrorResponseEntity.isSetTitle) && | |
| Objects.equals(this.type, defaultErrorResponseEntity.type) && | |
| Objects.equals(this.isSetType, defaultErrorResponseEntity.isSetType); |
| return Objects.equals(this.name, invalidField.name) && | ||
| Objects.equals(this.isSetName, invalidField.isSetName) && | ||
| Objects.equals(this.value, invalidField.value) && | ||
| Objects.equals(this.isSetValue, invalidField.isSetValue) && | ||
| Objects.equals(this.message, invalidField.message) && | ||
| Objects.equals(this.isSetMessage, invalidField.isSetMessage) | ||
| ; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The equals method has a trailing semicolon on a new line, which is unconventional and harms code readability. Please move the semicolon to the end of the return statement on the previous line.
| return Objects.equals(this.name, invalidField.name) && | |
| Objects.equals(this.isSetName, invalidField.isSetName) && | |
| Objects.equals(this.value, invalidField.value) && | |
| Objects.equals(this.isSetValue, invalidField.isSetValue) && | |
| Objects.equals(this.message, invalidField.message) && | |
| Objects.equals(this.isSetMessage, invalidField.isSetMessage) | |
| ; | |
| return Objects.equals(this.name, invalidField.name) && | |
| Objects.equals(this.isSetName, invalidField.isSetName) && | |
| Objects.equals(this.value, invalidField.value) && | |
| Objects.equals(this.isSetValue, invalidField.isSetValue) && | |
| Objects.equals(this.message, invalidField.message) && | |
| Objects.equals(this.isSetMessage, invalidField.isSetMessage); |
| return Objects.equals(this.installationId, paymentsAppDto.installationId) && | ||
| Objects.equals(this.isSetInstallationId, paymentsAppDto.isSetInstallationId) && | ||
| Objects.equals(this.merchantAccountCode, paymentsAppDto.merchantAccountCode) && | ||
| Objects.equals(this.isSetMerchantAccountCode, paymentsAppDto.isSetMerchantAccountCode) && | ||
| Objects.equals(this.merchantStoreCode, paymentsAppDto.merchantStoreCode) && | ||
| Objects.equals(this.isSetMerchantStoreCode, paymentsAppDto.isSetMerchantStoreCode) && | ||
| Objects.equals(this.status, paymentsAppDto.status) && | ||
| Objects.equals(this.isSetStatus, paymentsAppDto.isSetStatus) | ||
| ; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The equals method has a trailing semicolon on a new line, which is unconventional and harms code readability. Please move the semicolon to the end of the return statement on the previous line.
| return Objects.equals(this.installationId, paymentsAppDto.installationId) && | |
| Objects.equals(this.isSetInstallationId, paymentsAppDto.isSetInstallationId) && | |
| Objects.equals(this.merchantAccountCode, paymentsAppDto.merchantAccountCode) && | |
| Objects.equals(this.isSetMerchantAccountCode, paymentsAppDto.isSetMerchantAccountCode) && | |
| Objects.equals(this.merchantStoreCode, paymentsAppDto.merchantStoreCode) && | |
| Objects.equals(this.isSetMerchantStoreCode, paymentsAppDto.isSetMerchantStoreCode) && | |
| Objects.equals(this.status, paymentsAppDto.status) && | |
| Objects.equals(this.isSetStatus, paymentsAppDto.isSetStatus) | |
| ; | |
| return Objects.equals(this.installationId, paymentsAppDto.installationId) && | |
| Objects.equals(this.isSetInstallationId, paymentsAppDto.isSetInstallationId) && | |
| Objects.equals(this.merchantAccountCode, paymentsAppDto.merchantAccountCode) && | |
| Objects.equals(this.isSetMerchantAccountCode, paymentsAppDto.isSetMerchantAccountCode) && | |
| Objects.equals(this.merchantStoreCode, paymentsAppDto.merchantStoreCode) && | |
| Objects.equals(this.isSetMerchantStoreCode, paymentsAppDto.isSetMerchantStoreCode) && | |
| Objects.equals(this.status, paymentsAppDto.status) && | |
| Objects.equals(this.isSetStatus, paymentsAppDto.isSetStatus); |
| return Objects.equals(this.paymentsApps, paymentsAppResponse.paymentsApps) && | ||
| Objects.equals(this.isSetPaymentsApps, paymentsAppResponse.isSetPaymentsApps) | ||
| ; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The equals method has a trailing semicolon on a new line, which is unconventional and harms code readability. Please move the semicolon to the end of the return statement on the previous line.
| return Objects.equals(this.paymentsApps, paymentsAppResponse.paymentsApps) && | |
| Objects.equals(this.isSetPaymentsApps, paymentsAppResponse.isSetPaymentsApps) | |
| ; | |
| return Objects.equals(this.paymentsApps, paymentsAppResponse.paymentsApps) && | |
| Objects.equals(this.isSetPaymentsApps, paymentsAppResponse.isSetPaymentsApps); |
| public BoardingTokenResponse generatePaymentsAppBoardingTokenForMerchant(String merchantId, | ||
|
|
||
| /** | ||
| * Create a boarding token - merchant level | ||
| * | ||
| * @param merchantId {@link String } The unique identifier of the merchant account. (required) | ||
| * @param boardingTokenRequest {@link BoardingTokenRequest } (required) | ||
| * @param requestOptions {@link RequestOptions } Object to store additional HTTP headers such as | ||
| * idempotency-keys (optional) | ||
| * @return {@link BoardingTokenResponse } | ||
| * @throws ApiException if fails to make API call | ||
| */ | ||
| public BoardingTokenResponse generatePaymentsAppBoardingTokenForMerchant( | ||
| String merchantId, BoardingTokenRequest boardingTokenRequest, RequestOptions requestOptions) | ||
| throws ApiException, IOException { | ||
| // Add path params | ||
| Map<String, String> pathParams = new HashMap<>(); | ||
| if (merchantId == null) { | ||
| throw new IllegalArgumentException("Please provide the merchantId path parameter"); | ||
| BoardingTokenRequest boardingTokenRequest) throws ApiException, IOException { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is an unnecessary blank line within the method signature on line 65, which harms readability. This formatting issue is present in several other method signatures in this file as well. Please remove the extra blank lines from all affected method signatures.
public BoardingTokenResponse generatePaymentsAppBoardingTokenForMerchant(String merchantId, BoardingTokenRequest boardingTokenRequest) throws ApiException, IOException {8cec159 to
065fac2
Compare
aaf89dc to
bcfdca5
Compare
This PR contains the automated changes for the
paymentsappservice.The commit history of this PR reflects the
adyen-openapicommits that have been applied.