-
Notifications
You must be signed in to change notification settings - Fork 144
[disputewebhooks] Code generation: update services and models #1632
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Summary of ChangesHello @AdyenAutomationBot, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request delivers automated updates to the Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request appears to be an automated code generation update. The changes are mostly stylistic, but I've identified a couple of recurring formatting issues that seem to be bugs in the generator. Specifically, there's a stray semicolon in the equals methods and broken Javadoc comments for fromJson and toJson methods across several model files. Fixing these in the generator template would improve code quality and maintainability.
| return Objects.equals(this.currency, amount.currency) && | ||
| Objects.equals(this.value, amount.value) | ||
| ; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's a stray semicolon on a new line at the end of the return statement. While this is valid Java syntax (it's an empty statement), it's unconventional and harms readability. It should be removed. This seems to be a recurring issue in the generated code and might need a fix in the generator template.
| return Objects.equals(this.currency, amount.currency) && | |
| Objects.equals(this.value, amount.value) | |
| ; | |
| return Objects.equals(this.currency, amount.currency) && | |
| Objects.equals(this.value, amount.value); |
|
|
||
|
|
||
| /** |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| return Objects.equals(this.notificationResponse, balancePlatformNotificationResponse.notificationResponse) | ||
| ; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's a stray semicolon on a new line at the end of the return statement. While this is valid Java syntax (it's an empty statement), it's unconventional and harms readability. It should be removed. This seems to be a recurring issue in the generated code and might need a fix in the generator template.
| return Objects.equals(this.notificationResponse, balancePlatformNotificationResponse.notificationResponse) | |
| ; | |
| return Objects.equals(this.notificationResponse, balancePlatformNotificationResponse.notificationResponse); |
|
|
||
|
|
||
| /** |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| return Objects.equals(this.arn, disputeEventNotification.arn) && | ||
| Objects.equals(this.balancePlatform, disputeEventNotification.balancePlatform) && | ||
| Objects.equals(this.creationDate, disputeEventNotification.creationDate) && | ||
| Objects.equals(this.description, disputeEventNotification.description) && | ||
| Objects.equals(this.disputedAmount, disputeEventNotification.disputedAmount) && | ||
| Objects.equals(this.id, disputeEventNotification.id) && | ||
| Objects.equals(this.status, disputeEventNotification.status) && | ||
| Objects.equals(this.statusDetail, disputeEventNotification.statusDetail) && | ||
| Objects.equals(this.transactionId, disputeEventNotification.transactionId) && | ||
| Objects.equals(this.type, disputeEventNotification.type) | ||
| ; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's a stray semicolon on a new line at the end of the return statement. While this is valid Java syntax (it's an empty statement), it's unconventional and harms readability. It should be removed. This seems to be a recurring issue in the generated code and might need a fix in the generator template.
| return Objects.equals(this.arn, disputeEventNotification.arn) && | |
| Objects.equals(this.balancePlatform, disputeEventNotification.balancePlatform) && | |
| Objects.equals(this.creationDate, disputeEventNotification.creationDate) && | |
| Objects.equals(this.description, disputeEventNotification.description) && | |
| Objects.equals(this.disputedAmount, disputeEventNotification.disputedAmount) && | |
| Objects.equals(this.id, disputeEventNotification.id) && | |
| Objects.equals(this.status, disputeEventNotification.status) && | |
| Objects.equals(this.statusDetail, disputeEventNotification.statusDetail) && | |
| Objects.equals(this.transactionId, disputeEventNotification.transactionId) && | |
| Objects.equals(this.type, disputeEventNotification.type) | |
| ; | |
| return Objects.equals(this.arn, disputeEventNotification.arn) && | |
| Objects.equals(this.balancePlatform, disputeEventNotification.balancePlatform) && | |
| Objects.equals(this.creationDate, disputeEventNotification.creationDate) && | |
| Objects.equals(this.description, disputeEventNotification.description) && | |
| Objects.equals(this.disputedAmount, disputeEventNotification.disputedAmount) && | |
| Objects.equals(this.id, disputeEventNotification.id) && | |
| Objects.equals(this.status, disputeEventNotification.status) && | |
| Objects.equals(this.statusDetail, disputeEventNotification.statusDetail) && | |
| Objects.equals(this.transactionId, disputeEventNotification.transactionId) && | |
| Objects.equals(this.type, disputeEventNotification.type); |
|
|
||
|
|
||
| /** |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| return Objects.equals(this.data, disputeNotificationRequest.data) && | ||
| Objects.equals(this.type, disputeNotificationRequest.type) | ||
| ; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's a stray semicolon on a new line at the end of the return statement. While this is valid Java syntax (it's an empty statement), it's unconventional and harms readability. It should be removed. This seems to be a recurring issue in the generated code and might need a fix in the generator template.
| return Objects.equals(this.data, disputeNotificationRequest.data) && | |
| Objects.equals(this.type, disputeNotificationRequest.type) | |
| ; | |
| return Objects.equals(this.data, disputeNotificationRequest.data) && | |
| Objects.equals(this.type, disputeNotificationRequest.type); |
|
|
||
|
|
||
| /** |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
30e3082 to
11b3838
Compare
30f2070 to
be23d4d
Compare
This PR contains the automated changes for the
disputewebhooksservice.The commit history of this PR reflects the
adyen-openapicommits that have been applied.