-
Notifications
You must be signed in to change notification settings - Fork 144
[balancewebhooks] Code generation: update services and models #1635
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Summary of ChangesHello @AdyenAutomationBot, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request systematically updates the generated Java code for the Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request, which appears to be auto-generated, introduces several formatting changes. While many of these improve code style, there are critical compilation errors in multiple files due to invalid syntax in equals methods. Additionally, there are minor issues like unused imports and malformed Javadoc comments. These issues should be addressed in the code generation tool to prevent them from recurring.
| return Objects.equals(this.currency, amount.currency) && | ||
| Objects.equals(this.value, amount.value) | ||
| ; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is a syntax error here. The trailing semicolon on line 133 is invalid and will cause a compilation failure. This seems to be a recurring issue in the generated equals methods.
| return Objects.equals(this.currency, amount.currency) && | |
| Objects.equals(this.value, amount.value) | |
| ; | |
| return Objects.equals(this.currency, amount.currency) && | |
| Objects.equals(this.value, amount.value); |
| return Objects.equals(this.data, balanceAccountBalanceNotificationRequest.data) && | ||
| Objects.equals(this.environment, balanceAccountBalanceNotificationRequest.environment) && | ||
| Objects.equals(this.timestamp, balanceAccountBalanceNotificationRequest.timestamp) && | ||
| Objects.equals(this.type, balanceAccountBalanceNotificationRequest.type) | ||
| ; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is a syntax error here. The trailing semicolon on line 251 is invalid and will cause a compilation failure.
| return Objects.equals(this.data, balanceAccountBalanceNotificationRequest.data) && | |
| Objects.equals(this.environment, balanceAccountBalanceNotificationRequest.environment) && | |
| Objects.equals(this.timestamp, balanceAccountBalanceNotificationRequest.timestamp) && | |
| Objects.equals(this.type, balanceAccountBalanceNotificationRequest.type) | |
| ; | |
| return Objects.equals(this.data, balanceAccountBalanceNotificationRequest.data) && | |
| Objects.equals(this.environment, balanceAccountBalanceNotificationRequest.environment) && | |
| Objects.equals(this.timestamp, balanceAccountBalanceNotificationRequest.timestamp) && | |
| Objects.equals(this.type, balanceAccountBalanceNotificationRequest.type); |
| return Objects.equals(this.balanceAccountId, balanceNotificationData.balanceAccountId) && | ||
| Objects.equals(this.balancePlatform, balanceNotificationData.balancePlatform) && | ||
| Objects.equals(this.balances, balanceNotificationData.balances) && | ||
| Objects.equals(this.creationDate, balanceNotificationData.creationDate) && | ||
| Objects.equals(this.currency, balanceNotificationData.currency) && | ||
| Objects.equals(this.id, balanceNotificationData.id) && | ||
| Objects.equals(this.settingIds, balanceNotificationData.settingIds) | ||
| ; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is a syntax error here. The trailing semicolon on line 326 is invalid and will cause a compilation failure.
| return Objects.equals(this.balanceAccountId, balanceNotificationData.balanceAccountId) && | |
| Objects.equals(this.balancePlatform, balanceNotificationData.balancePlatform) && | |
| Objects.equals(this.balances, balanceNotificationData.balances) && | |
| Objects.equals(this.creationDate, balanceNotificationData.creationDate) && | |
| Objects.equals(this.currency, balanceNotificationData.currency) && | |
| Objects.equals(this.id, balanceNotificationData.id) && | |
| Objects.equals(this.settingIds, balanceNotificationData.settingIds) | |
| ; | |
| return Objects.equals(this.balanceAccountId, balanceNotificationData.balanceAccountId) && | |
| Objects.equals(this.balancePlatform, balanceNotificationData.balancePlatform) && | |
| Objects.equals(this.balances, balanceNotificationData.balances) && | |
| Objects.equals(this.creationDate, balanceNotificationData.creationDate) && | |
| Objects.equals(this.currency, balanceNotificationData.currency) && | |
| Objects.equals(this.id, balanceNotificationData.id) && | |
| Objects.equals(this.settingIds, balanceNotificationData.settingIds); |
| return Objects.equals(this.notificationResponse, balancePlatformNotificationResponse.notificationResponse) | ||
| ; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is a syntax error here. The trailing semicolon on line 94 is invalid and will cause a compilation failure.
| return Objects.equals(this.notificationResponse, balancePlatformNotificationResponse.notificationResponse) | |
| ; | |
| return Objects.equals(this.notificationResponse, balancePlatformNotificationResponse.notificationResponse); |
| return Objects.equals(this.available, balances.available) && | ||
| Objects.equals(this.balance, balances.balance) && | ||
| Objects.equals(this.pending, balances.pending) && | ||
| Objects.equals(this.reserved, balances.reserved) | ||
| ; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is a syntax error here. The trailing semicolon on line 211 is invalid and will cause a compilation failure.
| return Objects.equals(this.available, balances.available) && | |
| Objects.equals(this.balance, balances.balance) && | |
| Objects.equals(this.pending, balances.pending) && | |
| Objects.equals(this.reserved, balances.reserved) | |
| ; | |
| return Objects.equals(this.available, balances.available) && | |
| Objects.equals(this.balance, balances.balance) && | |
| Objects.equals(this.pending, balances.pending) && | |
| Objects.equals(this.reserved, balances.reserved); |
| return Objects.equals(this.data, releasedBlockedBalanceNotificationRequest.data) && | ||
| Objects.equals(this.environment, releasedBlockedBalanceNotificationRequest.environment) && | ||
| Objects.equals(this.timestamp, releasedBlockedBalanceNotificationRequest.timestamp) && | ||
| Objects.equals(this.type, releasedBlockedBalanceNotificationRequest.type) | ||
| ; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is a syntax error here. The trailing semicolon on line 251 is invalid and will cause a compilation failure.
| return Objects.equals(this.data, releasedBlockedBalanceNotificationRequest.data) && | |
| Objects.equals(this.environment, releasedBlockedBalanceNotificationRequest.environment) && | |
| Objects.equals(this.timestamp, releasedBlockedBalanceNotificationRequest.timestamp) && | |
| Objects.equals(this.type, releasedBlockedBalanceNotificationRequest.type) | |
| ; | |
| return Objects.equals(this.data, releasedBlockedBalanceNotificationRequest.data) && | |
| Objects.equals(this.environment, releasedBlockedBalanceNotificationRequest.environment) && | |
| Objects.equals(this.timestamp, releasedBlockedBalanceNotificationRequest.timestamp) && | |
| Objects.equals(this.type, releasedBlockedBalanceNotificationRequest.type); |
| return Objects.equals(this.description, resourceReference.description) && | ||
| Objects.equals(this.id, resourceReference.id) && | ||
| Objects.equals(this.reference, resourceReference.reference) | ||
| ; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is a syntax error here. The trailing semicolon on line 172 is invalid and will cause a compilation failure.
| return Objects.equals(this.description, resourceReference.description) && | |
| Objects.equals(this.id, resourceReference.id) && | |
| Objects.equals(this.reference, resourceReference.reference) | |
| ; | |
| return Objects.equals(this.description, resourceReference.description) && | |
| Objects.equals(this.id, resourceReference.id) && | |
| Objects.equals(this.reference, resourceReference.reference); |
| /** | ||
| * | ||
| * @param schemaType the schema type | ||
| * @param isNullable whether the instance is nullable | ||
| */ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This Javadoc comment is malformed. It has an extra blank line and is missing asterisks at the beginning of the blank line and at the end of the comment block. This issue is present in many of the generated files.
/**
* @param schemaType the schema type
* @param isNullable whether the instance is nullable
*/| import com.fasterxml.jackson.annotation.JsonIgnore; | ||
| import com.fasterxml.jackson.annotation.JsonAnyGetter; | ||
| import java.util.*; | ||
| import java.util.logging.Logger; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| import com.adyen.serializer.ByteArrayDeserializer; | ||
| import com.fasterxml.jackson.annotation.*; | ||
| import com.fasterxml.jackson.databind.*; | ||
| import com.fasterxml.jackson.databind.json.JsonMapper; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
04a17b1 to
fefe64a
Compare
3e8f7bd to
72bcf09
Compare
This PR contains the automated changes for the
balancewebhooksservice.The commit history of this PR reflects the
adyen-openapicommits that have been applied.