[dataprotection] Code generation: update services and models #1638

AdyenAutomationBot · 2026-01-05T15:20:05Z

This PR contains the automated changes for the dataprotection service.

The commit history of this PR reflects the adyen-openapi commits that have been applied.

gemini-code-assist · 2026-01-05T15:20:27Z

Summary of Changes

Hello @AdyenAutomationBot, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request delivers an automated update to the dataprotection service's generated code. The changes primarily involve standardizing import order, incorporating new necessary imports for various utility and Jackson annotations, and applying minor stylistic formatting adjustments across several model and API service files. These updates ensure the codebase remains aligned with the latest adyen-openapi generation standards.

Highlights

Automated Code Generation Update: The pull request introduces automated changes to the dataprotection service's code, reflecting updates from the adyen-openapi tool.
Import Reordering and Additions: Several Java files across models and services have had their import statements reordered and new imports added, including JsonMapper, Logger, JsonCreator, JsonTypeName, JsonValue, Arrays, HashMap, and Map.
Minor Formatting Adjustments: Consistent minor formatting changes, such as adjusting newlines, compacting Javadoc comments, and condensing single-line method definitions, have been applied across the modified files.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	`/gemini review`	Performs a code review for the current pull request in its current state.
Pull Request Summary	`/gemini summary`	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	`/gemini help`	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

gemini-code-assist

Code Review

This pull request focuses on improving code style and readability across several Java files, including AbstractOpenApiSchema.java, JSON.java, ServiceError.java, SubjectErasureByPspReferenceRequest.java, SubjectErasureResponse.java, and DataProtectionApi.java. The changes involve reordering imports, adding blank lines for better visual separation, and standardizing Javadoc comments by correcting malformed tags, ensuring proper line breaks, and making @return descriptions more concise. Additionally, the pull request enhances readability by expanding single-line methods into multi-line blocks, formatting long method signatures and hashCode implementations across multiple lines, and ensuring consistent K&R brace style for static blocks.

gemini-code-assist · 2026-01-05T15:23:06Z

src/main/java/com/adyen/model/dataprotection/AbstractOpenApiSchema.java

+    /**
+     *
+     * @param schemaType the schema type
+     * @param isNullable whether the instance is nullable
+    */


This Javadoc comment is malformed. According to standard Java conventions, there should not be a blank line after /**, and the closing */ should be on its own line and properly indented. Correcting this will improve code consistency and readability.

/** * @param schemaType the schema type * @param isNullable whether the instance is nullable */

gemini-code-assist · 2026-01-05T15:23:06Z

src/main/java/com/adyen/model/dataprotection/AbstractOpenApiSchema.java

+     * @return an instance of the actual schema/object
+     */
+    @JsonValue
+    public Object getActualInstance() {return instance;}


For better readability and to maintain a consistent coding style, it's recommended to expand single-line methods. This makes the code easier to read and debug.

public Object getActualInstance() { return instance; }

gemini-code-assist · 2026-01-05T15:23:06Z

src/main/java/com/adyen/model/dataprotection/AbstractOpenApiSchema.java

+     *
+     * @param instance the actual instance of the schema/object
+     */
+    public void setActualInstance(Object instance) {this.instance = instance;}


For better readability and to maintain a consistent coding style, it's recommended to expand single-line methods. This makes the code easier to read and debug.

public void setActualInstance(Object instance) { this.instance = instance; }

gemini-code-assist · 2026-01-05T15:23:06Z

src/main/java/com/adyen/model/dataprotection/JSON.java

-  public static ObjectMapper getMapper() {
-    return mapper;
-  }
+  public static ObjectMapper getMapper() { return mapper; }


To improve readability and maintain consistency with standard Java formatting, please expand this single-line method.

public static ObjectMapper getMapper() { return mapper; }

gemini-code-assist · 2026-01-05T15:23:06Z

src/main/java/com/adyen/model/dataprotection/JSON.java

+  public static void registerDiscriminator(Class<?> modelClass, String discriminatorPropertyName, Map<String, Class<?>> mappings) {
+    ClassDiscriminatorMapping m = new ClassDiscriminatorMapping(modelClass, discriminatorPropertyName, mappings);
    modelDiscriminators.put(modelClass, m);
  }


The method signature is excessively long, which harms readability. It's better to break it into multiple lines. The instantiation within the method can also be formatted for better clarity.

public static void registerDiscriminator( Class<?> modelClass, String discriminatorPropertyName, Map<String, Class<?>> mappings) { ClassDiscriminatorMapping m = new ClassDiscriminatorMapping(modelClass, discriminatorPropertyName, mappings); modelDiscriminators.put(modelClass, m); }

gemini-code-assist · 2026-01-05T15:23:07Z

src/main/java/com/adyen/model/dataprotection/SubjectErasureByPspReferenceRequest.java

+/**
+  * Convert an instance of SubjectErasureByPspReferenceRequest to an JSON string
+  *
+  * @return JSON string
+  */


The Javadoc comment is malformed. It should start with /** or have the description on the next line. This format is non-standard and should be corrected.

/** * Convert an instance of SubjectErasureByPspReferenceRequest to an JSON string * * @return JSON string */

gemini-code-assist · 2026-01-05T15:23:07Z

src/main/java/com/adyen/model/dataprotection/SubjectErasureResponse.java

-              + value
-              + "' - Supported values are "
-              + Arrays.toString(ResultEnum.values()));
+      LOG.warning("ResultEnum: unexpected enum value '" + value + "' - Supported values are "+ Arrays.toString(ResultEnum.values()));


This logging statement is a long one-liner, which harms readability. Please format it across multiple lines for better clarity.

LOG.warning( "ResultEnum: unexpected enum value '" + value + "' - Supported values are " + Arrays.toString(ResultEnum.values()));

gemini-code-assist · 2026-01-05T15:23:07Z

src/main/java/com/adyen/model/dataprotection/SubjectErasureResponse.java

+/**
   * Create an instance of SubjectErasureResponse given an JSON string
   *
   * @param jsonString JSON string
   * @return An instance of SubjectErasureResponse
-   * @throws JsonProcessingException if the JSON string is invalid with respect to
-   *     SubjectErasureResponse
+   * @throws JsonProcessingException if the JSON string is invalid with respect to SubjectErasureResponse
   */


The Javadoc comment is malformed. It should start with /** or have the description on the next line. This format is non-standard and should be corrected.

/** * Create an instance of SubjectErasureResponse given an JSON string * * @param jsonString JSON string * @return An instance of SubjectErasureResponse * @throws JsonProcessingException if the JSON string is invalid with respect to SubjectErasureResponse */

gemini-code-assist · 2026-01-05T15:23:07Z

src/main/java/com/adyen/model/dataprotection/SubjectErasureResponse.java

+/**
+  * Convert an instance of SubjectErasureResponse to an JSON string
+  *
+  * @return JSON string
+  */


The Javadoc comment is malformed. It should start with /** or have the description on the next line. This format is non-standard and should be corrected.

/** * Convert an instance of SubjectErasureResponse to an JSON string * * @return JSON string */

gemini-code-assist · 2026-01-05T15:23:07Z

src/main/java/com/adyen/service/dataprotection/DataProtectionApi.java

+    public SubjectErasureResponse requestSubjectErasure(SubjectErasureByPspReferenceRequest subjectErasureByPspReferenceRequest, RequestOptions requestOptions) throws ApiException, IOException {
+        String requestBody = subjectErasureByPspReferenceRequest.toJson();
+        Resource resource = new Resource(this, this.baseURL + "/requestSubjectErasure", null);
+        String jsonResult = resource.request(requestBody, requestOptions, ApiConstants.HttpMethod.POST, null);
+        return SubjectErasureResponse.fromJson(jsonResult);
+    }


This method signature is excessively long, making it difficult to read. For better readability, please break the signature into multiple lines.

public SubjectErasureResponse requestSubjectErasure( SubjectErasureByPspReferenceRequest subjectErasureByPspReferenceRequest, RequestOptions requestOptions) throws ApiException, IOException { String requestBody = subjectErasureByPspReferenceRequest.toJson(); Resource resource = new Resource(this, this.baseURL + "/requestSubjectErasure", null); String jsonResult = resource.request(requestBody, requestOptions, ApiConstants.HttpMethod.POST, null); return SubjectErasureResponse.fromJson(jsonResult); }

AdyenAutomationBot requested review from a team as code owners January 5, 2026 15:20

gemini-code-assist bot reviewed Jan 5, 2026

View reviewed changes

AdyenAutomationBot force-pushed the sdk-automation/dataprotection branch 3 times, most recently from f45a6a6 to 6f77ec0 Compare January 8, 2026 12:04

[dataprotection] Automated update from Adyen/adyen-openapi@0a007ce

b9439ae

AdyenAutomationBot force-pushed the sdk-automation/dataprotection branch from 50ead79 to b9439ae Compare January 8, 2026 14:34

style(fmt): code formatted

eae042a

[dataprotection] Code generation: update services and models #1638

Are you sure you want to change the base?

[dataprotection] Code generation: update services and models #1638

Uh oh!

Conversation

AdyenAutomationBot commented Jan 5, 2026

Uh oh!

gemini-code-assist bot commented Jan 5, 2026

Summary of Changes

Highlights

Footnotes

Uh oh!

gemini-code-assist bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

gemini-code-assist bot Jan 5, 2026

Choose a reason for hiding this comment

Uh oh!

gemini-code-assist bot Jan 5, 2026

Choose a reason for hiding this comment

Uh oh!

gemini-code-assist bot Jan 5, 2026

Choose a reason for hiding this comment

Uh oh!

gemini-code-assist bot Jan 5, 2026

Choose a reason for hiding this comment

Uh oh!

gemini-code-assist bot Jan 5, 2026

Choose a reason for hiding this comment

Uh oh!

gemini-code-assist bot Jan 5, 2026

Choose a reason for hiding this comment

Uh oh!

gemini-code-assist bot Jan 5, 2026

Choose a reason for hiding this comment

Uh oh!

gemini-code-assist bot Jan 5, 2026

Choose a reason for hiding this comment

Uh oh!

gemini-code-assist bot Jan 5, 2026

Choose a reason for hiding this comment

Uh oh!

gemini-code-assist bot Jan 5, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants