-
Notifications
You must be signed in to change notification settings - Fork 144
[balanceplatform] Code generation: update services and models #1644
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Summary of ChangesHello @AdyenAutomationBot, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request delivers an automated refresh of the Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request primarily focuses on code formatting and cleanup across multiple Java model files. Key changes include reordering import statements, adding empty lines for better readability, and removing redundant empty lines within Javadoc comments. A significant recurring change, highlighted in review comments, is the removal of trailing semicolons on new lines within equals methods, which were identified as empty statements affecting code readability. This issue, being present in auto-generated code, suggests a need for a fix in the OpenAPI Generator template itself. Additionally, the Balance model had its pendingAvailable property removed, and the BankAccountAccountIdentification model saw extensive import additions related to various local account identification types and JSON processing utilities, along with a refactoring of its setActualInstance method to use JSON.isInstanceOf for type checking against multiple oneOf schemas.
| return Objects.equals(this.accountNumber, auLocalAccountIdentification.accountNumber) && | ||
| Objects.equals(this.isSetAccountNumber, auLocalAccountIdentification.isSetAccountNumber) && | ||
| Objects.equals(this.bsbCode, auLocalAccountIdentification.bsbCode) && | ||
| Objects.equals(this.isSetBsbCode, auLocalAccountIdentification.isSetBsbCode) && | ||
| Objects.equals(this.type, auLocalAccountIdentification.type) && | ||
| Objects.equals(this.isSetType, auLocalAccountIdentification.isSetType) | ||
| ; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The equals method has a trailing semicolon on a new line, which is an empty statement. This affects code readability and should be removed. The semicolon should be at the end of the return statement. Since this is auto-generated code, this issue should ideally be fixed in the generator template.
| return Objects.equals(this.accountNumber, auLocalAccountIdentification.accountNumber) && | |
| Objects.equals(this.isSetAccountNumber, auLocalAccountIdentification.isSetAccountNumber) && | |
| Objects.equals(this.bsbCode, auLocalAccountIdentification.bsbCode) && | |
| Objects.equals(this.isSetBsbCode, auLocalAccountIdentification.isSetBsbCode) && | |
| Objects.equals(this.type, auLocalAccountIdentification.type) && | |
| Objects.equals(this.isSetType, auLocalAccountIdentification.isSetType) | |
| ; | |
| return Objects.equals(this.accountNumber, auLocalAccountIdentification.accountNumber) && | |
| Objects.equals(this.isSetAccountNumber, auLocalAccountIdentification.isSetAccountNumber) && | |
| Objects.equals(this.bsbCode, auLocalAccountIdentification.bsbCode) && | |
| Objects.equals(this.isSetBsbCode, auLocalAccountIdentification.isSetBsbCode) && | |
| Objects.equals(this.type, auLocalAccountIdentification.type) && | |
| Objects.equals(this.isSetType, auLocalAccountIdentification.isSetType); |
| return Objects.equals(this.balancePlatform, accountHolder.balancePlatform) && | ||
| Objects.equals(this.isSetBalancePlatform, accountHolder.isSetBalancePlatform) && | ||
| Objects.equals(this.capabilities, accountHolder.capabilities) && | ||
| Objects.equals(this.isSetCapabilities, accountHolder.isSetCapabilities) && | ||
| Objects.equals(this.contactDetails, accountHolder.contactDetails) && | ||
| Objects.equals(this.isSetContactDetails, accountHolder.isSetContactDetails) && | ||
| Objects.equals(this.description, accountHolder.description) && | ||
| Objects.equals(this.isSetDescription, accountHolder.isSetDescription) && | ||
| Objects.equals(this.id, accountHolder.id) && | ||
| Objects.equals(this.isSetId, accountHolder.isSetId) && | ||
| Objects.equals(this.legalEntityId, accountHolder.legalEntityId) && | ||
| Objects.equals(this.isSetLegalEntityId, accountHolder.isSetLegalEntityId) && | ||
| Objects.equals(this.metadata, accountHolder.metadata) && | ||
| Objects.equals(this.isSetMetadata, accountHolder.isSetMetadata) && | ||
| Objects.equals(this.migratedAccountHolderCode, accountHolder.migratedAccountHolderCode) && | ||
| Objects.equals(this.isSetMigratedAccountHolderCode, accountHolder.isSetMigratedAccountHolderCode) && | ||
| Objects.equals(this.primaryBalanceAccount, accountHolder.primaryBalanceAccount) && | ||
| Objects.equals(this.isSetPrimaryBalanceAccount, accountHolder.isSetPrimaryBalanceAccount) && | ||
| Objects.equals(this.reference, accountHolder.reference) && | ||
| Objects.equals(this.isSetReference, accountHolder.isSetReference) && | ||
| Objects.equals(this.status, accountHolder.status) && | ||
| Objects.equals(this.isSetStatus, accountHolder.isSetStatus) && | ||
| Objects.equals(this.timeZone, accountHolder.timeZone) && | ||
| Objects.equals(this.isSetTimeZone, accountHolder.isSetTimeZone) && | ||
| Objects.equals(this.verificationDeadlines, accountHolder.verificationDeadlines) && | ||
| Objects.equals(this.isSetVerificationDeadlines, accountHolder.isSetVerificationDeadlines) | ||
| ; | ||
| } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The equals method has a trailing semicolon on a new line, which is an empty statement. This affects code readability and should be removed. The semicolon should be at the end of the return statement. Since this is auto-generated code, this issue should ideally be fixed in the generator template.
return Objects.equals(this.balancePlatform, accountHolder.balancePlatform) &&
Objects.equals(this.isSetBalancePlatform, accountHolder.isSetBalancePlatform) &&
Objects.equals(this.capabilities, accountHolder.capabilities) &&
Objects.equals(this.isSetCapabilities, accountHolder.isSetCapabilities) &&
Objects.equals(this.contactDetails, accountHolder.contactDetails) &&
Objects.equals(this.isSetContactDetails, accountHolder.isSetContactDetails) &&
Objects.equals(this.description, accountHolder.description) &&
Objects.equals(this.isSetDescription, accountHolder.isSetDescription) &&
Objects.equals(this.id, accountHolder.id) &&
Objects.equals(this.isSetId, accountHolder.isSetId) &&
Objects.equals(this.legalEntityId, accountHolder.legalEntityId) &&
Objects.equals(this.isSetLegalEntityId, accountHolder.isSetLegalEntityId) &&
Objects.equals(this.metadata, accountHolder.metadata) &&
Objects.equals(this.isSetMetadata, accountHolder.isSetMetadata) &&
Objects.equals(this.migratedAccountHolderCode, accountHolder.migratedAccountHolderCode) &&
Objects.equals(this.isSetMigratedAccountHolderCode, accountHolder.isSetMigratedAccountHolderCode) &&
Objects.equals(this.primaryBalanceAccount, accountHolder.primaryBalanceAccount) &&
Objects.equals(this.isSetPrimaryBalanceAccount, accountHolder.isSetPrimaryBalanceAccount) &&
Objects.equals(this.reference, accountHolder.reference) &&
Objects.equals(this.isSetReference, accountHolder.isSetReference) &&
Objects.equals(this.status, accountHolder.status) &&
Objects.equals(this.isSetStatus, accountHolder.isSetStatus) &&
Objects.equals(this.timeZone, accountHolder.timeZone) &&
Objects.equals(this.isSetTimeZone, accountHolder.isSetTimeZone) &&
Objects.equals(this.verificationDeadlines, accountHolder.verificationDeadlines) &&
Objects.equals(this.isSetVerificationDeadlines, accountHolder.isSetVerificationDeadlines);| return Objects.equals(this.allowed, accountHolderCapability.allowed) && | ||
| Objects.equals(this.isSetAllowed, accountHolderCapability.isSetAllowed) && | ||
| Objects.equals(this.allowedLevel, accountHolderCapability.allowedLevel) && | ||
| Objects.equals(this.isSetAllowedLevel, accountHolderCapability.isSetAllowedLevel) && | ||
| Objects.equals(this.allowedSettings, accountHolderCapability.allowedSettings) && | ||
| Objects.equals(this.isSetAllowedSettings, accountHolderCapability.isSetAllowedSettings) && | ||
| Objects.equals(this.enabled, accountHolderCapability.enabled) && | ||
| Objects.equals(this.isSetEnabled, accountHolderCapability.isSetEnabled) && | ||
| Objects.equals(this.problems, accountHolderCapability.problems) && | ||
| Objects.equals(this.isSetProblems, accountHolderCapability.isSetProblems) && | ||
| Objects.equals(this.requested, accountHolderCapability.requested) && | ||
| Objects.equals(this.isSetRequested, accountHolderCapability.isSetRequested) && | ||
| Objects.equals(this.requestedLevel, accountHolderCapability.requestedLevel) && | ||
| Objects.equals(this.isSetRequestedLevel, accountHolderCapability.isSetRequestedLevel) && | ||
| Objects.equals(this.requestedSettings, accountHolderCapability.requestedSettings) && | ||
| Objects.equals(this.isSetRequestedSettings, accountHolderCapability.isSetRequestedSettings) && | ||
| Objects.equals(this.transferInstruments, accountHolderCapability.transferInstruments) && | ||
| Objects.equals(this.isSetTransferInstruments, accountHolderCapability.isSetTransferInstruments) && | ||
| Objects.equals(this.verificationStatus, accountHolderCapability.verificationStatus) && | ||
| Objects.equals(this.isSetVerificationStatus, accountHolderCapability.isSetVerificationStatus) | ||
| ; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The equals method has a trailing semicolon on a new line, which is an empty statement. This affects code readability and should be removed. The semicolon should be at the end of the return statement. Since this is auto-generated code, this issue should ideally be fixed in the generator template.
| return Objects.equals(this.allowed, accountHolderCapability.allowed) && | |
| Objects.equals(this.isSetAllowed, accountHolderCapability.isSetAllowed) && | |
| Objects.equals(this.allowedLevel, accountHolderCapability.allowedLevel) && | |
| Objects.equals(this.isSetAllowedLevel, accountHolderCapability.isSetAllowedLevel) && | |
| Objects.equals(this.allowedSettings, accountHolderCapability.allowedSettings) && | |
| Objects.equals(this.isSetAllowedSettings, accountHolderCapability.isSetAllowedSettings) && | |
| Objects.equals(this.enabled, accountHolderCapability.enabled) && | |
| Objects.equals(this.isSetEnabled, accountHolderCapability.isSetEnabled) && | |
| Objects.equals(this.problems, accountHolderCapability.problems) && | |
| Objects.equals(this.isSetProblems, accountHolderCapability.isSetProblems) && | |
| Objects.equals(this.requested, accountHolderCapability.requested) && | |
| Objects.equals(this.isSetRequested, accountHolderCapability.isSetRequested) && | |
| Objects.equals(this.requestedLevel, accountHolderCapability.requestedLevel) && | |
| Objects.equals(this.isSetRequestedLevel, accountHolderCapability.isSetRequestedLevel) && | |
| Objects.equals(this.requestedSettings, accountHolderCapability.requestedSettings) && | |
| Objects.equals(this.isSetRequestedSettings, accountHolderCapability.isSetRequestedSettings) && | |
| Objects.equals(this.transferInstruments, accountHolderCapability.transferInstruments) && | |
| Objects.equals(this.isSetTransferInstruments, accountHolderCapability.isSetTransferInstruments) && | |
| Objects.equals(this.verificationStatus, accountHolderCapability.verificationStatus) && | |
| Objects.equals(this.isSetVerificationStatus, accountHolderCapability.isSetVerificationStatus) | |
| ; | |
| return Objects.equals(this.allowed, accountHolderCapability.allowed) && | |
| Objects.equals(this.isSetAllowed, accountHolderCapability.isSetAllowed) && | |
| Objects.equals(this.allowedLevel, accountHolderCapability.allowedLevel) && | |
| Objects.equals(this.isSetAllowedLevel, accountHolderCapability.isSetAllowedLevel) && | |
| Objects.equals(this.allowedSettings, accountHolderCapability.allowedSettings) && | |
| Objects.equals(this.isSetAllowedSettings, accountHolderCapability.isSetAllowedSettings) && | |
| Objects.equals(this.enabled, accountHolderCapability.enabled) && | |
| Objects.equals(this.isSetEnabled, accountHolderCapability.isSetEnabled) && | |
| Objects.equals(this.problems, accountHolderCapability.problems) && | |
| Objects.equals(this.isSetProblems, accountHolderCapability.isSetProblems) && | |
| Objects.equals(this.requested, accountHolderCapability.requested) && | |
| Objects.equals(this.isSetRequested, accountHolderCapability.isSetRequested) && | |
| Objects.equals(this.requestedLevel, accountHolderCapability.requestedLevel) && | |
| Objects.equals(this.isSetRequestedLevel, accountHolderCapability.isSetRequestedLevel) && | |
| Objects.equals(this.requestedSettings, accountHolderCapability.requestedSettings) && | |
| Objects.equals(this.isSetRequestedSettings, accountHolderCapability.isSetRequestedSettings) && | |
| Objects.equals(this.transferInstruments, accountHolderCapability.transferInstruments) && | |
| Objects.equals(this.isSetTransferInstruments, accountHolderCapability.isSetTransferInstruments) && | |
| Objects.equals(this.verificationStatus, accountHolderCapability.verificationStatus) && | |
| Objects.equals(this.isSetVerificationStatus, accountHolderCapability.isSetVerificationStatus); |
| return Objects.equals(this.balancePlatform, accountHolderInfo.balancePlatform) && | ||
| Objects.equals(this.isSetBalancePlatform, accountHolderInfo.isSetBalancePlatform) && | ||
| Objects.equals(this.capabilities, accountHolderInfo.capabilities) && | ||
| Objects.equals(this.isSetCapabilities, accountHolderInfo.isSetCapabilities) && | ||
| Objects.equals(this.contactDetails, accountHolderInfo.contactDetails) && | ||
| Objects.equals(this.isSetContactDetails, accountHolderInfo.isSetContactDetails) && | ||
| Objects.equals(this.description, accountHolderInfo.description) && | ||
| Objects.equals(this.isSetDescription, accountHolderInfo.isSetDescription) && | ||
| Objects.equals(this.legalEntityId, accountHolderInfo.legalEntityId) && | ||
| Objects.equals(this.isSetLegalEntityId, accountHolderInfo.isSetLegalEntityId) && | ||
| Objects.equals(this.metadata, accountHolderInfo.metadata) && | ||
| Objects.equals(this.isSetMetadata, accountHolderInfo.isSetMetadata) && | ||
| Objects.equals(this.migratedAccountHolderCode, accountHolderInfo.migratedAccountHolderCode) && | ||
| Objects.equals(this.isSetMigratedAccountHolderCode, accountHolderInfo.isSetMigratedAccountHolderCode) && | ||
| Objects.equals(this.reference, accountHolderInfo.reference) && | ||
| Objects.equals(this.isSetReference, accountHolderInfo.isSetReference) && | ||
| Objects.equals(this.timeZone, accountHolderInfo.timeZone) && | ||
| Objects.equals(this.isSetTimeZone, accountHolderInfo.isSetTimeZone) | ||
| ; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The equals method has a trailing semicolon on a new line, which is an empty statement. This affects code readability and should be removed. The semicolon should be at the end of the return statement. Since this is auto-generated code, this issue should ideally be fixed in the generator template.
| return Objects.equals(this.balancePlatform, accountHolderInfo.balancePlatform) && | |
| Objects.equals(this.isSetBalancePlatform, accountHolderInfo.isSetBalancePlatform) && | |
| Objects.equals(this.capabilities, accountHolderInfo.capabilities) && | |
| Objects.equals(this.isSetCapabilities, accountHolderInfo.isSetCapabilities) && | |
| Objects.equals(this.contactDetails, accountHolderInfo.contactDetails) && | |
| Objects.equals(this.isSetContactDetails, accountHolderInfo.isSetContactDetails) && | |
| Objects.equals(this.description, accountHolderInfo.description) && | |
| Objects.equals(this.isSetDescription, accountHolderInfo.isSetDescription) && | |
| Objects.equals(this.legalEntityId, accountHolderInfo.legalEntityId) && | |
| Objects.equals(this.isSetLegalEntityId, accountHolderInfo.isSetLegalEntityId) && | |
| Objects.equals(this.metadata, accountHolderInfo.metadata) && | |
| Objects.equals(this.isSetMetadata, accountHolderInfo.isSetMetadata) && | |
| Objects.equals(this.migratedAccountHolderCode, accountHolderInfo.migratedAccountHolderCode) && | |
| Objects.equals(this.isSetMigratedAccountHolderCode, accountHolderInfo.isSetMigratedAccountHolderCode) && | |
| Objects.equals(this.reference, accountHolderInfo.reference) && | |
| Objects.equals(this.isSetReference, accountHolderInfo.isSetReference) && | |
| Objects.equals(this.timeZone, accountHolderInfo.timeZone) && | |
| Objects.equals(this.isSetTimeZone, accountHolderInfo.isSetTimeZone) | |
| ; | |
| return Objects.equals(this.balancePlatform, accountHolderInfo.balancePlatform) && | |
| Objects.equals(this.isSetBalancePlatform, accountHolderInfo.isSetBalancePlatform) && | |
| Objects.equals(this.capabilities, accountHolderInfo.capabilities) && | |
| Objects.equals(this.isSetCapabilities, accountHolderInfo.isSetCapabilities) && | |
| Objects.equals(this.contactDetails, accountHolderInfo.contactDetails) && | |
| Objects.equals(this.isSetContactDetails, accountHolderInfo.isSetContactDetails) && | |
| Objects.equals(this.description, accountHolderInfo.description) && | |
| Objects.equals(this.isSetDescription, accountHolderInfo.isSetDescription) && | |
| Objects.equals(this.legalEntityId, accountHolderInfo.legalEntityId) && | |
| Objects.equals(this.isSetLegalEntityId, accountHolderInfo.isSetLegalEntityId) && | |
| Objects.equals(this.metadata, accountHolderInfo.metadata) && | |
| Objects.equals(this.isSetMetadata, accountHolderInfo.isSetMetadata) && | |
| Objects.equals(this.migratedAccountHolderCode, accountHolderInfo.migratedAccountHolderCode) && | |
| Objects.equals(this.isSetMigratedAccountHolderCode, accountHolderInfo.isSetMigratedAccountHolderCode) && | |
| Objects.equals(this.reference, accountHolderInfo.reference) && | |
| Objects.equals(this.isSetReference, accountHolderInfo.isSetReference) && | |
| Objects.equals(this.timeZone, accountHolderInfo.timeZone) && | |
| Objects.equals(this.isSetTimeZone, accountHolderInfo.isSetTimeZone); |
| return Objects.equals(this.balancePlatform, accountHolderUpdateRequest.balancePlatform) && | ||
| Objects.equals(this.isSetBalancePlatform, accountHolderUpdateRequest.isSetBalancePlatform) && | ||
| Objects.equals(this.capabilities, accountHolderUpdateRequest.capabilities) && | ||
| Objects.equals(this.isSetCapabilities, accountHolderUpdateRequest.isSetCapabilities) && | ||
| Objects.equals(this.contactDetails, accountHolderUpdateRequest.contactDetails) && | ||
| Objects.equals(this.isSetContactDetails, accountHolderUpdateRequest.isSetContactDetails) && | ||
| Objects.equals(this.description, accountHolderUpdateRequest.description) && | ||
| Objects.equals(this.isSetDescription, accountHolderUpdateRequest.isSetDescription) && | ||
| Objects.equals(this.metadata, accountHolderUpdateRequest.metadata) && | ||
| Objects.equals(this.isSetMetadata, accountHolderUpdateRequest.isSetMetadata) && | ||
| Objects.equals(this.migratedAccountHolderCode, accountHolderUpdateRequest.migratedAccountHolderCode) && | ||
| Objects.equals(this.isSetMigratedAccountHolderCode, accountHolderUpdateRequest.isSetMigratedAccountHolderCode) && | ||
| Objects.equals(this.primaryBalanceAccount, accountHolderUpdateRequest.primaryBalanceAccount) && | ||
| Objects.equals(this.isSetPrimaryBalanceAccount, accountHolderUpdateRequest.isSetPrimaryBalanceAccount) && | ||
| Objects.equals(this.reference, accountHolderUpdateRequest.reference) && | ||
| Objects.equals(this.isSetReference, accountHolderUpdateRequest.isSetReference) && | ||
| Objects.equals(this.status, accountHolderUpdateRequest.status) && | ||
| Objects.equals(this.isSetStatus, accountHolderUpdateRequest.isSetStatus) && | ||
| Objects.equals(this.timeZone, accountHolderUpdateRequest.timeZone) && | ||
| Objects.equals(this.isSetTimeZone, accountHolderUpdateRequest.isSetTimeZone) && | ||
| Objects.equals(this.verificationDeadlines, accountHolderUpdateRequest.verificationDeadlines) && | ||
| Objects.equals(this.isSetVerificationDeadlines, accountHolderUpdateRequest.isSetVerificationDeadlines) | ||
| ; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The equals method has a trailing semicolon on a new line, which is an empty statement. This affects code readability and should be removed. The semicolon should be at the end of the return statement. Since this is auto-generated code, this issue should ideally be fixed in the generator template.
return Objects.equals(this.balancePlatform, accountHolderUpdateRequest.balancePlatform) &&
Objects.equals(this.isSetBalancePlatform, accountHolderUpdateRequest.isSetBalancePlatform) &&
Objects.equals(this.capabilities, accountHolderUpdateRequest.capabilities) &&
Objects.equals(this.isSetCapabilities, accountHolderUpdateRequest.isSetCapabilities) &&
Objects.equals(this.contactDetails, accountHolderUpdateRequest.contactDetails) &&
Objects.equals(this.isSetContactDetails, accountHolderUpdateRequest.isSetContactDetails) &&
Objects.equals(this.description, accountHolderUpdateRequest.description) &&
Objects.equals(this.isSetDescription, accountHolderUpdateRequest.isSetDescription) &&
Objects.equals(this.metadata, accountHolderUpdateRequest.metadata) &&
Objects.equals(this.isSetMetadata, accountHolderUpdateRequest.isSetMetadata) &&
Objects.equals(this.migratedAccountHolderCode, accountHolderUpdateRequest.migratedAccountHolderCode) &&
Objects.equals(this.isSetMigratedAccountHolderCode, accountHolderUpdateRequest.isSetMigratedAccountHolderCode) &&
Objects.equals(this.primaryBalanceAccount, accountHolderUpdateRequest.primaryBalanceAccount) &&
Objects.equals(this.isSetPrimaryBalanceAccount, accountHolderUpdateRequest.isSetPrimaryBalanceAccount) &&
Objects.equals(this.reference, accountHolderUpdateRequest.reference) &&
Objects.equals(this.isSetReference, accountHolderUpdateRequest.isSetReference) &&
Objects.equals(this.status, accountHolderUpdateRequest.status) &&
Objects.equals(this.isSetStatus, accountHolderUpdateRequest.isSetStatus) &&
Objects.equals(this.timeZone, accountHolderUpdateRequest.timeZone) &&
Objects.equals(this.isSetTimeZone, accountHolderUpdateRequest.isSetTimeZone) &&
Objects.equals(this.verificationDeadlines, accountHolderUpdateRequest.verificationDeadlines) &&
Objects.equals(this.isSetVerificationDeadlines, accountHolderUpdateRequest.isSetVerificationDeadlines);| return Objects.equals(this.conditions, balanceWebhookSettingInfoUpdate.conditions) && | ||
| Objects.equals(this.isSetConditions, balanceWebhookSettingInfoUpdate.isSetConditions) && | ||
| Objects.equals(this.currency, balanceWebhookSettingInfoUpdate.currency) && | ||
| Objects.equals(this.isSetCurrency, balanceWebhookSettingInfoUpdate.isSetCurrency) && | ||
| Objects.equals(this.status, balanceWebhookSettingInfoUpdate.status) && | ||
| Objects.equals(this.isSetStatus, balanceWebhookSettingInfoUpdate.isSetStatus) && | ||
| Objects.equals(this.target, balanceWebhookSettingInfoUpdate.target) && | ||
| Objects.equals(this.isSetTarget, balanceWebhookSettingInfoUpdate.isSetTarget) && | ||
| Objects.equals(this.type, balanceWebhookSettingInfoUpdate.type) && | ||
| Objects.equals(this.isSetType, balanceWebhookSettingInfoUpdate.isSetType) | ||
| ; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The equals method has a trailing semicolon on a new line, which is an empty statement. This affects code readability and should be removed. The semicolon should be at the end of the return statement. Since this is auto-generated code, this issue should ideally be fixed in the generator template.
| return Objects.equals(this.conditions, balanceWebhookSettingInfoUpdate.conditions) && | |
| Objects.equals(this.isSetConditions, balanceWebhookSettingInfoUpdate.isSetConditions) && | |
| Objects.equals(this.currency, balanceWebhookSettingInfoUpdate.currency) && | |
| Objects.equals(this.isSetCurrency, balanceWebhookSettingInfoUpdate.isSetCurrency) && | |
| Objects.equals(this.status, balanceWebhookSettingInfoUpdate.status) && | |
| Objects.equals(this.isSetStatus, balanceWebhookSettingInfoUpdate.isSetStatus) && | |
| Objects.equals(this.target, balanceWebhookSettingInfoUpdate.target) && | |
| Objects.equals(this.isSetTarget, balanceWebhookSettingInfoUpdate.isSetTarget) && | |
| Objects.equals(this.type, balanceWebhookSettingInfoUpdate.type) && | |
| Objects.equals(this.isSetType, balanceWebhookSettingInfoUpdate.isSetType) | |
| ; | |
| return Objects.equals(this.conditions, balanceWebhookSettingInfoUpdate.conditions) && | |
| Objects.equals(this.isSetConditions, balanceWebhookSettingInfoUpdate.isSetConditions) && | |
| Objects.equals(this.currency, balanceWebhookSettingInfoUpdate.currency) && | |
| Objects.equals(this.isSetCurrency, balanceWebhookSettingInfoUpdate.isSetCurrency) && | |
| Objects.equals(this.status, balanceWebhookSettingInfoUpdate.status) && | |
| Objects.equals(this.isSetStatus, balanceWebhookSettingInfoUpdate.isSetStatus) && | |
| Objects.equals(this.target, balanceWebhookSettingInfoUpdate.target) && | |
| Objects.equals(this.isSetTarget, balanceWebhookSettingInfoUpdate.isSetTarget) && | |
| Objects.equals(this.type, balanceWebhookSettingInfoUpdate.type) && | |
| Objects.equals(this.isSetType, balanceWebhookSettingInfoUpdate.isSetType); |
| return Objects.equals(this.accountIdentification, bankAccount.accountIdentification) && | ||
| Objects.equals(this.isSetAccountIdentification, bankAccount.isSetAccountIdentification) | ||
| ; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The equals method has a trailing semicolon on a new line, which is an empty statement. This affects code readability and should be removed. The semicolon should be at the end of the return statement. Since this is auto-generated code, this issue should ideally be fixed in the generator template.
| return Objects.equals(this.accountIdentification, bankAccount.accountIdentification) && | |
| Objects.equals(this.isSetAccountIdentification, bankAccount.isSetAccountIdentification) | |
| ; | |
| return Objects.equals(this.accountIdentification, bankAccount.accountIdentification) && | |
| Objects.equals(this.isSetAccountIdentification, bankAccount.isSetAccountIdentification); |
| return Objects.equals(this.accountNumber, bankAccountDetails.accountNumber) && | ||
| Objects.equals(this.isSetAccountNumber, bankAccountDetails.isSetAccountNumber) && | ||
| Objects.equals(this.accountType, bankAccountDetails.accountType) && | ||
| Objects.equals(this.isSetAccountType, bankAccountDetails.isSetAccountType) && | ||
| Objects.equals(this.branchNumber, bankAccountDetails.branchNumber) && | ||
| Objects.equals(this.isSetBranchNumber, bankAccountDetails.isSetBranchNumber) && | ||
| Objects.equals(this.formFactor, bankAccountDetails.formFactor) && | ||
| Objects.equals(this.isSetFormFactor, bankAccountDetails.isSetFormFactor) && | ||
| Objects.equals(this.iban, bankAccountDetails.iban) && | ||
| Objects.equals(this.isSetIban, bankAccountDetails.isSetIban) && | ||
| Objects.equals(this.routingNumber, bankAccountDetails.routingNumber) && | ||
| Objects.equals(this.isSetRoutingNumber, bankAccountDetails.isSetRoutingNumber) && | ||
| Objects.equals(this.sortCode, bankAccountDetails.sortCode) && | ||
| Objects.equals(this.isSetSortCode, bankAccountDetails.isSetSortCode) && | ||
| Objects.equals(this.type, bankAccountDetails.type) && | ||
| Objects.equals(this.isSetType, bankAccountDetails.isSetType) | ||
| ; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The equals method has a trailing semicolon on a new line, which is an empty statement. This affects code readability and should be removed. The semicolon should be at the end of the return statement. Since this is auto-generated code, this issue should ideally be fixed in the generator template.
| return Objects.equals(this.accountNumber, bankAccountDetails.accountNumber) && | |
| Objects.equals(this.isSetAccountNumber, bankAccountDetails.isSetAccountNumber) && | |
| Objects.equals(this.accountType, bankAccountDetails.accountType) && | |
| Objects.equals(this.isSetAccountType, bankAccountDetails.isSetAccountType) && | |
| Objects.equals(this.branchNumber, bankAccountDetails.branchNumber) && | |
| Objects.equals(this.isSetBranchNumber, bankAccountDetails.isSetBranchNumber) && | |
| Objects.equals(this.formFactor, bankAccountDetails.formFactor) && | |
| Objects.equals(this.isSetFormFactor, bankAccountDetails.isSetFormFactor) && | |
| Objects.equals(this.iban, bankAccountDetails.iban) && | |
| Objects.equals(this.isSetIban, bankAccountDetails.isSetIban) && | |
| Objects.equals(this.routingNumber, bankAccountDetails.routingNumber) && | |
| Objects.equals(this.isSetRoutingNumber, bankAccountDetails.isSetRoutingNumber) && | |
| Objects.equals(this.sortCode, bankAccountDetails.sortCode) && | |
| Objects.equals(this.isSetSortCode, bankAccountDetails.isSetSortCode) && | |
| Objects.equals(this.type, bankAccountDetails.type) && | |
| Objects.equals(this.isSetType, bankAccountDetails.isSetType) | |
| ; | |
| return Objects.equals(this.accountNumber, bankAccountDetails.accountNumber) && | |
| Objects.equals(this.isSetAccountNumber, bankAccountDetails.isSetAccountNumber) && | |
| Objects.equals(this.accountType, bankAccountDetails.accountType) && | |
| Objects.equals(this.isSetAccountType, bankAccountDetails.isSetAccountType) && | |
| Objects.equals(this.branchNumber, bankAccountDetails.branchNumber) && | |
| Objects.equals(this.isSetBranchNumber, bankAccountDetails.isSetBranchNumber) && | |
| Objects.equals(this.formFactor, bankAccountDetails.formFactor) && | |
| Objects.equals(this.isSetFormFactor, bankAccountDetails.isSetFormFactor) && | |
| Objects.equals(this.iban, bankAccountDetails.iban) && | |
| Objects.equals(this.isSetIban, bankAccountDetails.isSetIban) && | |
| Objects.equals(this.routingNumber, bankAccountDetails.routingNumber) && | |
| Objects.equals(this.isSetRoutingNumber, bankAccountDetails.isSetRoutingNumber) && | |
| Objects.equals(this.sortCode, bankAccountDetails.sortCode) && | |
| Objects.equals(this.isSetSortCode, bankAccountDetails.isSetSortCode) && | |
| Objects.equals(this.type, bankAccountDetails.type) && | |
| Objects.equals(this.isSetType, bankAccountDetails.isSetType); |
| return Objects.equals(this.bankAccountIdentificationTypes, bankAccountIdentificationTypeRequirement.bankAccountIdentificationTypes) && | ||
| Objects.equals(this.isSetBankAccountIdentificationTypes, bankAccountIdentificationTypeRequirement.isSetBankAccountIdentificationTypes) && | ||
| Objects.equals(this.description, bankAccountIdentificationTypeRequirement.description) && | ||
| Objects.equals(this.isSetDescription, bankAccountIdentificationTypeRequirement.isSetDescription) && | ||
| Objects.equals(this.type, bankAccountIdentificationTypeRequirement.type) && | ||
| Objects.equals(this.isSetType, bankAccountIdentificationTypeRequirement.isSetType) | ||
| ; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The equals method has a trailing semicolon on a new line, which is an empty statement. This affects code readability and should be removed. The semicolon should be at the end of the return statement. Since this is auto-generated code, this issue should ideally be fixed in the generator template.
| return Objects.equals(this.bankAccountIdentificationTypes, bankAccountIdentificationTypeRequirement.bankAccountIdentificationTypes) && | |
| Objects.equals(this.isSetBankAccountIdentificationTypes, bankAccountIdentificationTypeRequirement.isSetBankAccountIdentificationTypes) && | |
| Objects.equals(this.description, bankAccountIdentificationTypeRequirement.description) && | |
| Objects.equals(this.isSetDescription, bankAccountIdentificationTypeRequirement.isSetDescription) && | |
| Objects.equals(this.type, bankAccountIdentificationTypeRequirement.type) && | |
| Objects.equals(this.isSetType, bankAccountIdentificationTypeRequirement.isSetType) | |
| ; | |
| return Objects.equals(this.bankAccountIdentificationTypes, bankAccountIdentificationTypeRequirement.bankAccountIdentificationTypes) && | |
| Objects.equals(this.isSetBankAccountIdentificationTypes, bankAccountIdentificationTypeRequirement.isSetBankAccountIdentificationTypes) && | |
| Objects.equals(this.description, bankAccountIdentificationTypeRequirement.description) && | |
| Objects.equals(this.isSetDescription, bankAccountIdentificationTypeRequirement.isSetDescription) && | |
| Objects.equals(this.type, bankAccountIdentificationTypeRequirement.type) && | |
| Objects.equals(this.isSetType, bankAccountIdentificationTypeRequirement.isSetType); |
| return Objects.equals(this.accountIdentification, bankAccountIdentificationValidationRequest.accountIdentification) && | ||
| Objects.equals(this.isSetAccountIdentification, bankAccountIdentificationValidationRequest.isSetAccountIdentification) | ||
| ; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The equals method has a trailing semicolon on a new line, which is an empty statement. This affects code readability and should be removed. The semicolon should be at the end of the return statement. Since this is auto-generated code, this issue should ideally be fixed in the generator template.
| return Objects.equals(this.accountIdentification, bankAccountIdentificationValidationRequest.accountIdentification) && | |
| Objects.equals(this.isSetAccountIdentification, bankAccountIdentificationValidationRequest.isSetAccountIdentification) | |
| ; | |
| return Objects.equals(this.accountIdentification, bankAccountIdentificationValidationRequest.accountIdentification) && | |
| Objects.equals(this.isSetAccountIdentification, bankAccountIdentificationValidationRequest.isSetAccountIdentification); |
67a271a to
9763301
Compare
b26247f to
426fcf1
Compare
This PR contains the automated changes for the
balanceplatformservice.The commit history of this PR reflects the
adyen-openapicommits that have been applied.