[transactionwebhooks] Code generation: update services and models

[AdyenAutomationBot]

This PR contains the automated changes for the transactionwebhooks service.

The commit history of this PR reflects the adyen-openapi commits that have been applied.

[gemini-code-assist]

Summary of Changes

Hello @AdyenAutomationBot, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request delivers an automated update to the transactionwebhooks service, ensuring its models and services align with the most recent adyen-openapi specification. The changes primarily involve reordering and adding necessary imports, alongside a significant effort to refine and expand Javadoc comments across various classes for improved code readability and understanding. A key functional enhancement is the introduction of the DCCMarkup enum value, which provides more granular categorization for platform payment types.

Highlights

• OpenAPI Model Updates: The core transaction webhooks service models have been updated, reflecting the latest OpenAPI specification.
• Enhanced Javadoc Documentation: Numerous model classes received comprehensive Javadoc updates, improving clarity and detail for fields, enums, and methods.
• New Platform Payment Type: The PlatformPaymentTypeEnum now includes DCCMarkup, expanding the categorization of platform payments.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request, generated automatically, introduces several updates to services and models. While it includes functional improvements such as the addition of new enum members and enhanced deserialization logic for oneOf schemas, it also brings in a number of formatting regressions across multiple files. These include inconsistent indentation, single-line method bodies that reduce readability, long concatenated strings, incorrectly formatted Javadocs, and unconventional semicolon placements. I've provided specific comments on these formatting issues. It would be beneficial to review the code generation templates to prevent these style problems in future updates and ensure code quality and maintainability.

[gemini-code-assist]

For better readability and to adhere to standard Java coding conventions, it's recommended to format method bodies on multiple lines, even for single-line methods. This improves maintainability and makes debugging easier. This formatting issue is present in other methods in this file and across other files in this pull request.

    public Object getActualInstance() {
        return instance;
    }

[gemini-code-assist]

The trailing semicolon on a new line is unconventional and harms readability. It should be placed on the same line as the expression.

Suggested change

	return Objects.equals(this.currency, amount.currency) &&
	Objects.equals(this.value, amount.value)
	;
	return Objects.equals(this.currency, amount.currency) &&
	Objects.equals(this.value, amount.value);

[gemini-code-assist]

The Javadoc for toJson is incorrectly formatted. It should start on a new line and be properly indented for readability and to follow standard Java conventions.

Suggested change

	/**
	* Convert an instance of Amount to an JSON string
	*
	* @return JSON string
	*/
	/**
	* Convert an instance of Amount to an JSON string
	*
	* @return JSON string
	*/

[gemini-code-assist]

The trailing semicolon on a new line is unconventional and harms readability. It should be placed on the same line as the expression.

Suggested change

	return Objects.equals(this.notificationResponse, balancePlatformNotificationResponse.notificationResponse)
	;
	return Objects.equals(this.notificationResponse, balancePlatformNotificationResponse.notificationResponse);

[gemini-code-assist]

The Javadoc for toJson is incorrectly formatted. It should start on a new line and be properly indented for readability and to follow standard Java conventions.

Suggested change

	/**
	* Convert an instance of BalancePlatformNotificationResponse to an JSON string
	*
	* @return JSON string
	*/
	/**
	* Convert an instance of BalancePlatformNotificationResponse to an JSON string
	*
	* @return JSON string
	*/

[gemini-code-assist]

The trailing semicolon on a new line is unconventional and harms readability. It should be placed on the same line as the expression.

Suggested change

	return Objects.equals(this.acsTransactionId, threeDSecure.acsTransactionId)
	;
	return Objects.equals(this.acsTransactionId, threeDSecure.acsTransactionId);

[gemini-code-assist]

The trailing semicolon on a new line is unconventional and harms readability. It should be placed on the same line as the expression.

Suggested change

	return Objects.equals(this.accountHolder, transaction.accountHolder) &&
	Objects.equals(this.amount, transaction.amount) &&
	Objects.equals(this.balanceAccount, transaction.balanceAccount) &&
	Objects.equals(this.balancePlatform, transaction.balancePlatform) &&
	Objects.equals(this.bookingDate, transaction.bookingDate) &&
	Objects.equals(this.creationDate, transaction.creationDate) &&
	Objects.equals(this.description, transaction.description) &&
	Objects.equals(this.id, transaction.id) &&
	Objects.equals(this.paymentInstrument, transaction.paymentInstrument) &&
	Objects.equals(this.referenceForBeneficiary, transaction.referenceForBeneficiary) &&
	Objects.equals(this.status, transaction.status) &&
	Objects.equals(this.transfer, transaction.transfer) &&
	Objects.equals(this.valueDate, transaction.valueDate)
	;
	return Objects.equals(this.accountHolder, transaction.accountHolder) &&
	Objects.equals(this.amount, transaction.amount) &&
	Objects.equals(this.balanceAccount, transaction.balanceAccount) &&
	Objects.equals(this.balancePlatform, transaction.balancePlatform) &&
	Objects.equals(this.bookingDate, transaction.bookingDate) &&
	Objects.equals(this.creationDate, transaction.creationDate) &&
	Objects.equals(this.description, transaction.description) &&
	Objects.equals(this.id, transaction.id) &&
	Objects.equals(this.paymentInstrument, transaction.paymentInstrument) &&
	Objects.equals(this.referenceForBeneficiary, transaction.referenceForBeneficiary) &&
	Objects.equals(this.status, transaction.status) &&
	Objects.equals(this.transfer, transaction.transfer) &&
	Objects.equals(this.valueDate, transaction.valueDate);

[gemini-code-assist]

The trailing semicolon on a new line is unconventional and harms readability. It should be placed on the same line as the expression.

Suggested change

	return Objects.equals(this.data, transactionNotificationRequestV4.data) &&
	Objects.equals(this.environment, transactionNotificationRequestV4.environment) &&
	Objects.equals(this.timestamp, transactionNotificationRequestV4.timestamp) &&
	Objects.equals(this.type, transactionNotificationRequestV4.type)
	;
	return Objects.equals(this.data, transactionNotificationRequestV4.data) &&
	Objects.equals(this.environment, transactionNotificationRequestV4.environment) &&
	Objects.equals(this.timestamp, transactionNotificationRequestV4.timestamp) &&
	Objects.equals(this.type, transactionNotificationRequestV4.type);

[gemini-code-assist]

The trailing semicolon on a new line is unconventional and harms readability. It should be placed on the same line as the expression.

Suggested change

	return Objects.equals(this.result, transferNotificationValidationFact.result) &&
	Objects.equals(this.type, transferNotificationValidationFact.type)
	;
	return Objects.equals(this.result, transferNotificationValidationFact.result) &&
	Objects.equals(this.type, transferNotificationValidationFact.type);

[gemini-code-assist]

The trailing semicolon on a new line is unconventional and harms readability. It should be placed on the same line as the expression.

Suggested change

	return Objects.equals(this.categoryData, transferView.categoryData) &&
	Objects.equals(this.id, transferView.id) &&
	Objects.equals(this.reference, transferView.reference)
	;
	return Objects.equals(this.categoryData, transferView.categoryData) &&
	Objects.equals(this.id, transferView.id) &&
	Objects.equals(this.reference, transferView.reference);