-
Notifications
You must be signed in to change notification settings - Fork 144
[payment] Code generation: update services and models #1649
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Summary of ChangesHello @AdyenAutomationBot, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request automates updates to the Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request appears to be an automated update from a code generator, introducing changes across many model classes. The primary change is the addition of isSet... flags and related logic to handle explicit null values during JSON serialization. This is a valuable improvement for API clarity, distinguishing between fields that are absent and those that are explicitly set to null.
However, the code generation process has also introduced some formatting changes that negatively impact code readability. Specifically, some multi-line log statements and Javadoc comments have been converted into very long single lines, making them difficult to read and maintain. I've added a few specific comments to highlight these areas. It would be beneficial to adjust the code generator's templates to preserve or improve formatting for better readability in the future.
| + value | ||
| + "' - Supported values are " | ||
| + Arrays.toString(AccountAgeIndicatorEnum.values())); | ||
| LOG.warning("AccountAgeIndicatorEnum: unexpected enum value '" + value + "' - Supported values are "+ Arrays.toString(AccountAgeIndicatorEnum.values())); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| + value | ||
| + "' - Supported values are " | ||
| + Arrays.toString(ChAccAgeIndEnum.values())); | ||
| LOG.warning("ChAccAgeIndEnum: unexpected enum value '" + value + "' - Supported values are "+ Arrays.toString(ChAccAgeIndEnum.values())); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| * authorization rates and improve the shopper's experience. * **false** – Not ready to | ||
| * support native 3D Secure 2 authentication. Adyen offers redirect 3D Secure 2 authentication | ||
| * instead, based on your configuration. | ||
| * Indicates if you are able to process 3D Secure 2 transactions natively on your payment page. Send this parameter when you are using `/payments` endpoint with any of our [native 3D Secure 2 solutions](https://docs.adyen.com/online-payments/3d-secure/native-3ds2). > This parameter only indicates readiness to support native 3D Secure 2 authentication. To specify if you _want_ to perform 3D Secure, use [Dynamic 3D Secure](/risk-management/dynamic-3d-secure) or send the `executeThreeD` parameter. Possible values: * **true** - Ready to support native 3D Secure 2 authentication. Setting this to true does not mean always applying 3D Secure 2. Adyen selects redirect or native authentication based on your configuration to optimize authorization rates and improve the shopper's experience. * **false** – Not ready to support native 3D Secure 2 authentication. Adyen offers redirect 3D Secure 2 authentication instead, based on your configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
0c53fcd to
42e1887
Compare
d8bb5b1 to
f8af53b
Compare
This PR contains the automated changes for the
paymentservice.The commit history of this PR reflects the
adyen-openapicommits that have been applied.