Skip to content

Conversation

@AdyenAutomationBot
Copy link
Collaborator

This PR contains the automated changes for the payment service.

The commit history of this PR reflects the adyen-openapi commits that have been applied.

@AdyenAutomationBot AdyenAutomationBot requested review from a team as code owners January 5, 2026 15:20
@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @AdyenAutomationBot, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request automates updates to the payment service, focusing on model and service code generation. The changes include modifications to existing data models to enhance data handling and serialization, as well as updates to the core abstract schema.

Highlights

  • Code Generation Update: This PR contains automated code generation updates for the payment service, including modifications to services and models.
  • AbstractOpenApiSchema.java: The AbstractOpenApiSchema.java file was modified to adjust the package declaration and import statements, and to ensure that the class ends with a newline character.
  • AccountInfo.java and AcctInfo.java: The AccountInfo.java and AcctInfo.java files were modified to add explicit isSet boolean flags for each property, include null values, and update enum handling.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request appears to be an automated update from a code generator, introducing changes across many model classes. The primary change is the addition of isSet... flags and related logic to handle explicit null values during JSON serialization. This is a valuable improvement for API clarity, distinguishing between fields that are absent and those that are explicitly set to null.

However, the code generation process has also introduced some formatting changes that negatively impact code readability. Specifically, some multi-line log statements and Javadoc comments have been converted into very long single lines, making them difficult to read and maintain. I've added a few specific comments to highlight these areas. It would be beneficial to adjust the code generator's templates to preserve or improve formatting for better readability in the future.

+ value
+ "' - Supported values are "
+ Arrays.toString(AccountAgeIndicatorEnum.values()));
LOG.warning("AccountAgeIndicatorEnum: unexpected enum value '" + value + "' - Supported values are "+ Arrays.toString(AccountAgeIndicatorEnum.values()));
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

This line has become very long due to the string concatenation, which harms readability. It would be better to keep the LOG.warning call as a multi-line statement for better readability and maintainability. This comment applies to other similar changes in this file and others in this PR.

+ value
+ "' - Supported values are "
+ Arrays.toString(ChAccAgeIndEnum.values()));
LOG.warning("ChAccAgeIndEnum: unexpected enum value '" + value + "' - Supported values are "+ Arrays.toString(ChAccAgeIndEnum.values()));
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

Similar to my other comment, this long line for the LOG.warning call reduces code readability. Please consider breaking it into multiple lines to improve maintainability.

* authorization rates and improve the shopper&#39;s experience. * **false** – Not ready to
* support native 3D Secure 2 authentication. Adyen offers redirect 3D Secure 2 authentication
* instead, based on your configuration.
* Indicates if you are able to process 3D Secure 2 transactions natively on your payment page. Send this parameter when you are using &#x60;/payments&#x60; endpoint with any of our [native 3D Secure 2 solutions](https://docs.adyen.com/online-payments/3d-secure/native-3ds2). &gt; This parameter only indicates readiness to support native 3D Secure 2 authentication. To specify if you _want_ to perform 3D Secure, use [Dynamic 3D Secure](/risk-management/dynamic-3d-secure) or send the &#x60;executeThreeD&#x60; parameter. Possible values: * **true** - Ready to support native 3D Secure 2 authentication. Setting this to true does not mean always applying 3D Secure 2. Adyen selects redirect or native authentication based on your configuration to optimize authorization rates and improve the shopper&#39;s experience. * **false** – Not ready to support native 3D Secure 2 authentication. Adyen offers redirect 3D Secure 2 authentication instead, based on your configuration.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

This Javadoc comment has been flattened into a single, very long line, which makes it difficult to read. Please reintroduce line breaks to improve readability. This applies to other long Javadoc comments in this PR as well.

@AdyenAutomationBot AdyenAutomationBot force-pushed the sdk-automation/payment branch 3 times, most recently from 0c53fcd to 42e1887 Compare January 8, 2026 12:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants