-
Notifications
You must be signed in to change notification settings - Fork 144
[sessionauthentication] Code generation: update services and models #1651
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Summary of ChangesHello @AdyenAutomationBot, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request delivers an automated update to the Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request appears to be an automated update from an OpenAPI generator, resulting in widespread formatting changes across numerous files. While most changes are stylistic, I've identified several critical issues that will cause compilation errors, specifically trailing semicolons in the equals methods of multiple model classes. Additionally, there are several medium-severity issues related to inconsistent Javadoc formatting, non-standard code block formatting, and reduced code readability that should be addressed to maintain code quality.
| return Objects.equals(this.allowOrigin, authenticationSessionRequest.allowOrigin) && | ||
| Objects.equals(this.isSetAllowOrigin, authenticationSessionRequest.isSetAllowOrigin) && | ||
| Objects.equals(this.policy, authenticationSessionRequest.policy) && | ||
| Objects.equals(this.isSetPolicy, authenticationSessionRequest.isSetPolicy) && | ||
| Objects.equals(this.product, authenticationSessionRequest.product) && | ||
| Objects.equals(this.isSetProduct, authenticationSessionRequest.isSetProduct) | ||
| ; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is a stray semicolon at the end of the return statement, which will cause a compilation error.
| return Objects.equals(this.allowOrigin, authenticationSessionRequest.allowOrigin) && | |
| Objects.equals(this.isSetAllowOrigin, authenticationSessionRequest.isSetAllowOrigin) && | |
| Objects.equals(this.policy, authenticationSessionRequest.policy) && | |
| Objects.equals(this.isSetPolicy, authenticationSessionRequest.isSetPolicy) && | |
| Objects.equals(this.product, authenticationSessionRequest.product) && | |
| Objects.equals(this.isSetProduct, authenticationSessionRequest.isSetProduct) | |
| ; | |
| return Objects.equals(this.allowOrigin, authenticationSessionRequest.allowOrigin) && | |
| Objects.equals(this.isSetAllowOrigin, authenticationSessionRequest.isSetAllowOrigin) && | |
| Objects.equals(this.policy, authenticationSessionRequest.policy) && | |
| Objects.equals(this.isSetPolicy, authenticationSessionRequest.isSetPolicy) && | |
| Objects.equals(this.product, authenticationSessionRequest.product) && | |
| Objects.equals(this.isSetProduct, authenticationSessionRequest.isSetProduct); |
| return Objects.equals(this.id, authenticationSessionResponse.id) && | ||
| Objects.equals(this.isSetId, authenticationSessionResponse.isSetId) && | ||
| Objects.equals(this.token, authenticationSessionResponse.token) && | ||
| Objects.equals(this.isSetToken, authenticationSessionResponse.isSetToken) | ||
| ; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is a stray semicolon at the end of the return statement, which will cause a compilation error.
| return Objects.equals(this.id, authenticationSessionResponse.id) && | |
| Objects.equals(this.isSetId, authenticationSessionResponse.isSetId) && | |
| Objects.equals(this.token, authenticationSessionResponse.token) && | |
| Objects.equals(this.isSetToken, authenticationSessionResponse.isSetToken) | |
| ; | |
| return Objects.equals(this.id, authenticationSessionResponse.id) && | |
| Objects.equals(this.isSetId, authenticationSessionResponse.isSetId) && | |
| Objects.equals(this.token, authenticationSessionResponse.token) && | |
| Objects.equals(this.isSetToken, authenticationSessionResponse.isSetToken); |
| return Objects.equals(this.detail, defaultErrorResponseEntity.detail) && | ||
| Objects.equals(this.isSetDetail, defaultErrorResponseEntity.isSetDetail) && | ||
| Objects.equals(this.errorCode, defaultErrorResponseEntity.errorCode) && | ||
| Objects.equals(this.isSetErrorCode, defaultErrorResponseEntity.isSetErrorCode) && | ||
| Objects.equals(this.instance, defaultErrorResponseEntity.instance) && | ||
| Objects.equals(this.isSetInstance, defaultErrorResponseEntity.isSetInstance) && | ||
| Objects.equals(this.invalidFields, defaultErrorResponseEntity.invalidFields) && | ||
| Objects.equals(this.isSetInvalidFields, defaultErrorResponseEntity.isSetInvalidFields) && | ||
| Objects.equals(this.requestId, defaultErrorResponseEntity.requestId) && | ||
| Objects.equals(this.isSetRequestId, defaultErrorResponseEntity.isSetRequestId) && | ||
| Objects.equals(this.status, defaultErrorResponseEntity.status) && | ||
| Objects.equals(this.isSetStatus, defaultErrorResponseEntity.isSetStatus) && | ||
| Objects.equals(this.title, defaultErrorResponseEntity.title) && | ||
| Objects.equals(this.isSetTitle, defaultErrorResponseEntity.isSetTitle) && | ||
| Objects.equals(this.type, defaultErrorResponseEntity.type) && | ||
| Objects.equals(this.isSetType, defaultErrorResponseEntity.isSetType) | ||
| ; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is a stray semicolon at the end of the return statement, which will cause a compilation error.
| return Objects.equals(this.detail, defaultErrorResponseEntity.detail) && | |
| Objects.equals(this.isSetDetail, defaultErrorResponseEntity.isSetDetail) && | |
| Objects.equals(this.errorCode, defaultErrorResponseEntity.errorCode) && | |
| Objects.equals(this.isSetErrorCode, defaultErrorResponseEntity.isSetErrorCode) && | |
| Objects.equals(this.instance, defaultErrorResponseEntity.instance) && | |
| Objects.equals(this.isSetInstance, defaultErrorResponseEntity.isSetInstance) && | |
| Objects.equals(this.invalidFields, defaultErrorResponseEntity.invalidFields) && | |
| Objects.equals(this.isSetInvalidFields, defaultErrorResponseEntity.isSetInvalidFields) && | |
| Objects.equals(this.requestId, defaultErrorResponseEntity.requestId) && | |
| Objects.equals(this.isSetRequestId, defaultErrorResponseEntity.isSetRequestId) && | |
| Objects.equals(this.status, defaultErrorResponseEntity.status) && | |
| Objects.equals(this.isSetStatus, defaultErrorResponseEntity.isSetStatus) && | |
| Objects.equals(this.title, defaultErrorResponseEntity.title) && | |
| Objects.equals(this.isSetTitle, defaultErrorResponseEntity.isSetTitle) && | |
| Objects.equals(this.type, defaultErrorResponseEntity.type) && | |
| Objects.equals(this.isSetType, defaultErrorResponseEntity.isSetType) | |
| ; | |
| return Objects.equals(this.detail, defaultErrorResponseEntity.detail) && | |
| Objects.equals(this.isSetDetail, defaultErrorResponseEntity.isSetDetail) && | |
| Objects.equals(this.errorCode, defaultErrorResponseEntity.errorCode) && | |
| Objects.equals(this.isSetErrorCode, defaultErrorResponseEntity.isSetErrorCode) && | |
| Objects.equals(this.instance, defaultErrorResponseEntity.instance) && | |
| Objects.equals(this.isSetInstance, defaultErrorResponseEntity.isSetInstance) && | |
| Objects.equals(this.invalidFields, defaultErrorResponseEntity.invalidFields) && | |
| Objects.equals(this.isSetInvalidFields, defaultErrorResponseEntity.isSetInvalidFields) && | |
| Objects.equals(this.requestId, defaultErrorResponseEntity.requestId) && | |
| Objects.equals(this.isSetRequestId, defaultErrorResponseEntity.isSetRequestId) && | |
| Objects.equals(this.status, defaultErrorResponseEntity.status) && | |
| Objects.equals(this.isSetStatus, defaultErrorResponseEntity.isSetStatus) && | |
| Objects.equals(this.title, defaultErrorResponseEntity.title) && | |
| Objects.equals(this.isSetTitle, defaultErrorResponseEntity.isSetTitle) && | |
| Objects.equals(this.type, defaultErrorResponseEntity.type) && | |
| Objects.equals(this.isSetType, defaultErrorResponseEntity.isSetType); |
| return Objects.equals(this.name, invalidField.name) && | ||
| Objects.equals(this.isSetName, invalidField.isSetName) && | ||
| Objects.equals(this.value, invalidField.value) && | ||
| Objects.equals(this.isSetValue, invalidField.isSetValue) && | ||
| Objects.equals(this.message, invalidField.message) && | ||
| Objects.equals(this.isSetMessage, invalidField.isSetMessage) | ||
| ; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is a stray semicolon at the end of the return statement, which will cause a compilation error.
| return Objects.equals(this.name, invalidField.name) && | |
| Objects.equals(this.isSetName, invalidField.isSetName) && | |
| Objects.equals(this.value, invalidField.value) && | |
| Objects.equals(this.isSetValue, invalidField.isSetValue) && | |
| Objects.equals(this.message, invalidField.message) && | |
| Objects.equals(this.isSetMessage, invalidField.isSetMessage) | |
| ; | |
| return Objects.equals(this.name, invalidField.name) && | |
| Objects.equals(this.isSetName, invalidField.isSetName) && | |
| Objects.equals(this.value, invalidField.value) && | |
| Objects.equals(this.isSetValue, invalidField.isSetValue) && | |
| Objects.equals(this.message, invalidField.message) && | |
| Objects.equals(this.isSetMessage, invalidField.isSetMessage); |
| return Objects.equals(this.resources, policy.resources) && | ||
| Objects.equals(this.isSetResources, policy.isSetResources) && | ||
| Objects.equals(this.roles, policy.roles) && | ||
| Objects.equals(this.isSetRoles, policy.isSetRoles) | ||
| ; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is a stray semicolon at the end of the return statement, which will cause a compilation error.
| return Objects.equals(this.resources, policy.resources) && | |
| Objects.equals(this.isSetResources, policy.isSetResources) && | |
| Objects.equals(this.roles, policy.roles) && | |
| Objects.equals(this.isSetRoles, policy.isSetRoles) | |
| ; | |
| return Objects.equals(this.resources, policy.resources) && | |
| Objects.equals(this.isSetResources, policy.isSetResources) && | |
| Objects.equals(this.roles, policy.roles) && | |
| Objects.equals(this.isSetRoles, policy.isSetRoles); |
| return Objects.equals(this.type, resource.type) && | ||
| Objects.equals(this.isSetType, resource.isSetType) | ||
| ; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is a stray semicolon at the end of the return statement, which will cause a compilation error.
| return Objects.equals(this.type, resource.type) && | |
| Objects.equals(this.isSetType, resource.isSetType) | |
| ; | |
| return Objects.equals(this.type, resource.type) && | |
| Objects.equals(this.isSetType, resource.isSetType); |
| /** | ||
| * Create an instance of AccountHolderResource given an JSON string | ||
| * | ||
| * @param jsonString JSON string | ||
| * @return An instance of AccountHolderResource | ||
| * @throws JsonProcessingException if the JSON string is invalid with respect to | ||
| * AccountHolderResource | ||
| * @throws JsonProcessingException if the JSON string is invalid with respect to AccountHolderResource | ||
| */ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The Javadoc for this method is not formatted correctly. The /** should be indented to match the method and should be followed by a space or a newline with * on the next line. This issue is present for fromJson and toJson methods in multiple model files.
| /** | |
| * Create an instance of AccountHolderResource given an JSON string | |
| * | |
| * @param jsonString JSON string | |
| * @return An instance of AccountHolderResource | |
| * @throws JsonProcessingException if the JSON string is invalid with respect to | |
| * AccountHolderResource | |
| * @throws JsonProcessingException if the JSON string is invalid with respect to AccountHolderResource | |
| */ | |
| /** | |
| * Create an instance of AccountHolderResource given an JSON string | |
| * | |
| * @param jsonString JSON string | |
| * @return An instance of AccountHolderResource | |
| * @throws JsonProcessingException if the JSON string is invalid with respect to AccountHolderResource | |
| */ |
| /** | ||
| * Convert an instance of AccountHolderResource to an JSON string | ||
| * | ||
| * @return JSON string | ||
| */ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The Javadoc for this method is not formatted correctly. The /** should be indented to match the method and should be followed by a space or a newline with * on the next line. This issue is present for fromJson and toJson methods in multiple model files.
| /** | |
| * Convert an instance of AccountHolderResource to an JSON string | |
| * | |
| * @return JSON string | |
| */ | |
| /** | |
| * Convert an instance of AccountHolderResource to an JSON string | |
| * | |
| * @return JSON string | |
| */ |
| public int hashCode() { | ||
| return Objects.hash( | ||
| detail, | ||
| isSetDetail, | ||
| errorCode, | ||
| isSetErrorCode, | ||
| instance, | ||
| isSetInstance, | ||
| invalidFields, | ||
| isSetInvalidFields, | ||
| requestId, | ||
| isSetRequestId, | ||
| status, | ||
| isSetStatus, | ||
| title, | ||
| isSetTitle, | ||
| type, | ||
| isSetType); | ||
| return Objects.hash(detail, isSetDetail, errorCode, isSetErrorCode, instance, isSetInstance, invalidFields, isSetInvalidFields, requestId, isSetRequestId, status, isSetStatus, title, isSetTitle, type, isSetType); | ||
| } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This long line in hashCode is difficult to read. It would be better to format it across multiple lines for improved readability, as it was before this change.
| public int hashCode() { | |
| return Objects.hash( | |
| detail, | |
| isSetDetail, | |
| errorCode, | |
| isSetErrorCode, | |
| instance, | |
| isSetInstance, | |
| invalidFields, | |
| isSetInvalidFields, | |
| requestId, | |
| isSetRequestId, | |
| status, | |
| isSetStatus, | |
| title, | |
| isSetTitle, | |
| type, | |
| isSetType); | |
| return Objects.hash(detail, isSetDetail, errorCode, isSetErrorCode, instance, isSetInstance, invalidFields, isSetInvalidFields, requestId, isSetRequestId, status, isSetStatus, title, isSetTitle, type, isSetType); | |
| } | |
| public int hashCode() { | |
| return Objects.hash( | |
| detail, | |
| isSetDetail, | |
| errorCode, | |
| isSetErrorCode, | |
| instance, | |
| isSetInstance, | |
| invalidFields, | |
| isSetInvalidFields, | |
| requestId, | |
| isSetRequestId, | |
| status, | |
| isSetStatus, | |
| title, | |
| isSetTitle, | |
| type, | |
| isSetType); | |
| } |
| static | ||
| { | ||
| json = new JSON(); | ||
| } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
7320678 to
f8a1cef
Compare
975ddf3 to
261a5a6
Compare
This PR contains the automated changes for the
sessionauthenticationservice.The commit history of this PR reflects the
adyen-openapicommits that have been applied.