Skip to content

Conversation

@AdyenAutomationBot
Copy link
Collaborator

This PR contains the automated changes for the sessionauthentication service.

The commit history of this PR reflects the adyen-openapi commits that have been applied.

@AdyenAutomationBot AdyenAutomationBot requested review from a team as code owners January 5, 2026 15:20
@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @AdyenAutomationBot, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request delivers an automated update to the sessionauthentication service's generated code. The changes are largely cosmetic and structural, ensuring consistency and adherence to the latest OpenAPI specification. This includes reformatting across various model classes, as well as minor adjustments to the API client and utility classes.

Highlights

  • Automated Code Generation: This pull request incorporates automated updates to the sessionauthentication service, reflecting recent changes from the adyen-openapi specification.
  • Code Formatting and Structure: Numerous model classes have undergone minor formatting adjustments, including reordering of import statements, rewrapping of Javadoc comments, and consistent formatting of annotations like @JsonPropertyOrder and @JsonTypeInfo.
  • API Client Updates: The SessionAuthenticationApi class has received minor updates, primarily involving import reordering and subtle modifications to method signatures for consistency with the generated code.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request appears to be an automated update from an OpenAPI generator, resulting in widespread formatting changes across numerous files. While most changes are stylistic, I've identified several critical issues that will cause compilation errors, specifically trailing semicolons in the equals methods of multiple model classes. Additionally, there are several medium-severity issues related to inconsistent Javadoc formatting, non-standard code block formatting, and reduced code readability that should be addressed to maintain code quality.

Comment on lines 196 to 202
return Objects.equals(this.allowOrigin, authenticationSessionRequest.allowOrigin) &&
Objects.equals(this.isSetAllowOrigin, authenticationSessionRequest.isSetAllowOrigin) &&
Objects.equals(this.policy, authenticationSessionRequest.policy) &&
Objects.equals(this.isSetPolicy, authenticationSessionRequest.isSetPolicy) &&
Objects.equals(this.product, authenticationSessionRequest.product) &&
Objects.equals(this.isSetProduct, authenticationSessionRequest.isSetProduct)
;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

critical

There is a stray semicolon at the end of the return statement, which will cause a compilation error.

Suggested change
return Objects.equals(this.allowOrigin, authenticationSessionRequest.allowOrigin) &&
Objects.equals(this.isSetAllowOrigin, authenticationSessionRequest.isSetAllowOrigin) &&
Objects.equals(this.policy, authenticationSessionRequest.policy) &&
Objects.equals(this.isSetPolicy, authenticationSessionRequest.isSetPolicy) &&
Objects.equals(this.product, authenticationSessionRequest.product) &&
Objects.equals(this.isSetProduct, authenticationSessionRequest.isSetProduct)
;
return Objects.equals(this.allowOrigin, authenticationSessionRequest.allowOrigin) &&
Objects.equals(this.isSetAllowOrigin, authenticationSessionRequest.isSetAllowOrigin) &&
Objects.equals(this.policy, authenticationSessionRequest.policy) &&
Objects.equals(this.isSetPolicy, authenticationSessionRequest.isSetPolicy) &&
Objects.equals(this.product, authenticationSessionRequest.product) &&
Objects.equals(this.isSetProduct, authenticationSessionRequest.isSetProduct);

Comment on lines 154 to 158
return Objects.equals(this.id, authenticationSessionResponse.id) &&
Objects.equals(this.isSetId, authenticationSessionResponse.isSetId) &&
Objects.equals(this.token, authenticationSessionResponse.token) &&
Objects.equals(this.isSetToken, authenticationSessionResponse.isSetToken)
;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

critical

There is a stray semicolon at the end of the return statement, which will cause a compilation error.

Suggested change
return Objects.equals(this.id, authenticationSessionResponse.id) &&
Objects.equals(this.isSetId, authenticationSessionResponse.isSetId) &&
Objects.equals(this.token, authenticationSessionResponse.token) &&
Objects.equals(this.isSetToken, authenticationSessionResponse.isSetToken)
;
return Objects.equals(this.id, authenticationSessionResponse.id) &&
Objects.equals(this.isSetId, authenticationSessionResponse.isSetId) &&
Objects.equals(this.token, authenticationSessionResponse.token) &&
Objects.equals(this.isSetToken, authenticationSessionResponse.isSetToken);

Comment on lines 405 to 421
return Objects.equals(this.detail, defaultErrorResponseEntity.detail) &&
Objects.equals(this.isSetDetail, defaultErrorResponseEntity.isSetDetail) &&
Objects.equals(this.errorCode, defaultErrorResponseEntity.errorCode) &&
Objects.equals(this.isSetErrorCode, defaultErrorResponseEntity.isSetErrorCode) &&
Objects.equals(this.instance, defaultErrorResponseEntity.instance) &&
Objects.equals(this.isSetInstance, defaultErrorResponseEntity.isSetInstance) &&
Objects.equals(this.invalidFields, defaultErrorResponseEntity.invalidFields) &&
Objects.equals(this.isSetInvalidFields, defaultErrorResponseEntity.isSetInvalidFields) &&
Objects.equals(this.requestId, defaultErrorResponseEntity.requestId) &&
Objects.equals(this.isSetRequestId, defaultErrorResponseEntity.isSetRequestId) &&
Objects.equals(this.status, defaultErrorResponseEntity.status) &&
Objects.equals(this.isSetStatus, defaultErrorResponseEntity.isSetStatus) &&
Objects.equals(this.title, defaultErrorResponseEntity.title) &&
Objects.equals(this.isSetTitle, defaultErrorResponseEntity.isSetTitle) &&
Objects.equals(this.type, defaultErrorResponseEntity.type) &&
Objects.equals(this.isSetType, defaultErrorResponseEntity.isSetType)
;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

critical

There is a stray semicolon at the end of the return statement, which will cause a compilation error.

Suggested change
return Objects.equals(this.detail, defaultErrorResponseEntity.detail) &&
Objects.equals(this.isSetDetail, defaultErrorResponseEntity.isSetDetail) &&
Objects.equals(this.errorCode, defaultErrorResponseEntity.errorCode) &&
Objects.equals(this.isSetErrorCode, defaultErrorResponseEntity.isSetErrorCode) &&
Objects.equals(this.instance, defaultErrorResponseEntity.instance) &&
Objects.equals(this.isSetInstance, defaultErrorResponseEntity.isSetInstance) &&
Objects.equals(this.invalidFields, defaultErrorResponseEntity.invalidFields) &&
Objects.equals(this.isSetInvalidFields, defaultErrorResponseEntity.isSetInvalidFields) &&
Objects.equals(this.requestId, defaultErrorResponseEntity.requestId) &&
Objects.equals(this.isSetRequestId, defaultErrorResponseEntity.isSetRequestId) &&
Objects.equals(this.status, defaultErrorResponseEntity.status) &&
Objects.equals(this.isSetStatus, defaultErrorResponseEntity.isSetStatus) &&
Objects.equals(this.title, defaultErrorResponseEntity.title) &&
Objects.equals(this.isSetTitle, defaultErrorResponseEntity.isSetTitle) &&
Objects.equals(this.type, defaultErrorResponseEntity.type) &&
Objects.equals(this.isSetType, defaultErrorResponseEntity.isSetType)
;
return Objects.equals(this.detail, defaultErrorResponseEntity.detail) &&
Objects.equals(this.isSetDetail, defaultErrorResponseEntity.isSetDetail) &&
Objects.equals(this.errorCode, defaultErrorResponseEntity.errorCode) &&
Objects.equals(this.isSetErrorCode, defaultErrorResponseEntity.isSetErrorCode) &&
Objects.equals(this.instance, defaultErrorResponseEntity.instance) &&
Objects.equals(this.isSetInstance, defaultErrorResponseEntity.isSetInstance) &&
Objects.equals(this.invalidFields, defaultErrorResponseEntity.invalidFields) &&
Objects.equals(this.isSetInvalidFields, defaultErrorResponseEntity.isSetInvalidFields) &&
Objects.equals(this.requestId, defaultErrorResponseEntity.requestId) &&
Objects.equals(this.isSetRequestId, defaultErrorResponseEntity.isSetRequestId) &&
Objects.equals(this.status, defaultErrorResponseEntity.status) &&
Objects.equals(this.isSetStatus, defaultErrorResponseEntity.isSetStatus) &&
Objects.equals(this.title, defaultErrorResponseEntity.title) &&
Objects.equals(this.isSetTitle, defaultErrorResponseEntity.isSetTitle) &&
Objects.equals(this.type, defaultErrorResponseEntity.type) &&
Objects.equals(this.isSetType, defaultErrorResponseEntity.isSetType);

Comment on lines 194 to 200
return Objects.equals(this.name, invalidField.name) &&
Objects.equals(this.isSetName, invalidField.isSetName) &&
Objects.equals(this.value, invalidField.value) &&
Objects.equals(this.isSetValue, invalidField.isSetValue) &&
Objects.equals(this.message, invalidField.message) &&
Objects.equals(this.isSetMessage, invalidField.isSetMessage)
;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

critical

There is a stray semicolon at the end of the return statement, which will cause a compilation error.

Suggested change
return Objects.equals(this.name, invalidField.name) &&
Objects.equals(this.isSetName, invalidField.isSetName) &&
Objects.equals(this.value, invalidField.value) &&
Objects.equals(this.isSetValue, invalidField.isSetValue) &&
Objects.equals(this.message, invalidField.message) &&
Objects.equals(this.isSetMessage, invalidField.isSetMessage)
;
return Objects.equals(this.name, invalidField.name) &&
Objects.equals(this.isSetName, invalidField.isSetName) &&
Objects.equals(this.value, invalidField.value) &&
Objects.equals(this.isSetValue, invalidField.isSetValue) &&
Objects.equals(this.message, invalidField.message) &&
Objects.equals(this.isSetMessage, invalidField.isSetMessage);

Comment on lines 176 to 180
return Objects.equals(this.resources, policy.resources) &&
Objects.equals(this.isSetResources, policy.isSetResources) &&
Objects.equals(this.roles, policy.roles) &&
Objects.equals(this.isSetRoles, policy.isSetRoles)
;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

critical

There is a stray semicolon at the end of the return statement, which will cause a compilation error.

Suggested change
return Objects.equals(this.resources, policy.resources) &&
Objects.equals(this.isSetResources, policy.isSetResources) &&
Objects.equals(this.roles, policy.roles) &&
Objects.equals(this.isSetRoles, policy.isSetRoles)
;
return Objects.equals(this.resources, policy.resources) &&
Objects.equals(this.isSetResources, policy.isSetResources) &&
Objects.equals(this.roles, policy.roles) &&
Objects.equals(this.isSetRoles, policy.isSetRoles);

Comment on lines 131 to 133
return Objects.equals(this.type, resource.type) &&
Objects.equals(this.isSetType, resource.isSetType)
;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

critical

There is a stray semicolon at the end of the return statement, which will cause a compilation error.

Suggested change
return Objects.equals(this.type, resource.type) &&
Objects.equals(this.isSetType, resource.isSetType)
;
return Objects.equals(this.type, resource.type) &&
Objects.equals(this.isSetType, resource.isSetType);

Comment on lines 188 to 194
/**
* Create an instance of AccountHolderResource given an JSON string
*
* @param jsonString JSON string
* @return An instance of AccountHolderResource
* @throws JsonProcessingException if the JSON string is invalid with respect to
* AccountHolderResource
* @throws JsonProcessingException if the JSON string is invalid with respect to AccountHolderResource
*/
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The Javadoc for this method is not formatted correctly. The /** should be indented to match the method and should be followed by a space or a newline with * on the next line. This issue is present for fromJson and toJson methods in multiple model files.

Suggested change
/**
* Create an instance of AccountHolderResource given an JSON string
*
* @param jsonString JSON string
* @return An instance of AccountHolderResource
* @throws JsonProcessingException if the JSON string is invalid with respect to
* AccountHolderResource
* @throws JsonProcessingException if the JSON string is invalid with respect to AccountHolderResource
*/
/**
* Create an instance of AccountHolderResource given an JSON string
*
* @param jsonString JSON string
* @return An instance of AccountHolderResource
* @throws JsonProcessingException if the JSON string is invalid with respect to AccountHolderResource
*/

Comment on lines 198 to 202
/**
* Convert an instance of AccountHolderResource to an JSON string
*
* @return JSON string
*/
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The Javadoc for this method is not formatted correctly. The /** should be indented to match the method and should be followed by a space or a newline with * on the next line. This issue is present for fromJson and toJson methods in multiple model files.

Suggested change
/**
* Convert an instance of AccountHolderResource to an JSON string
*
* @return JSON string
*/
/**
* Convert an instance of AccountHolderResource to an JSON string
*
* @return JSON string
*/

Comment on lines 425 to 427
public int hashCode() {
return Objects.hash(
detail,
isSetDetail,
errorCode,
isSetErrorCode,
instance,
isSetInstance,
invalidFields,
isSetInvalidFields,
requestId,
isSetRequestId,
status,
isSetStatus,
title,
isSetTitle,
type,
isSetType);
return Objects.hash(detail, isSetDetail, errorCode, isSetErrorCode, instance, isSetInstance, invalidFields, isSetInvalidFields, requestId, isSetRequestId, status, isSetStatus, title, isSetTitle, type, isSetType);
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

This long line in hashCode is difficult to read. It would be better to format it across multiple lines for improved readability, as it was before this change.

Suggested change
public int hashCode() {
return Objects.hash(
detail,
isSetDetail,
errorCode,
isSetErrorCode,
instance,
isSetInstance,
invalidFields,
isSetInvalidFields,
requestId,
isSetRequestId,
status,
isSetStatus,
title,
isSetTitle,
type,
isSetType);
return Objects.hash(detail, isSetDetail, errorCode, isSetErrorCode, instance, isSetInstance, invalidFields, isSetInvalidFields, requestId, isSetRequestId, status, isSetStatus, title, isSetTitle, type, isSetType);
}
public int hashCode() {
return Objects.hash(
detail,
isSetDetail,
errorCode,
isSetErrorCode,
instance,
isSetInstance,
invalidFields,
isSetInvalidFields,
requestId,
isSetRequestId,
status,
isSetStatus,
title,
isSetTitle,
type,
isSetType);
}

Comment on lines 231 to 234
static
{
json = new JSON();
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The formatting of this static initializer block is unconventional. For better readability and adherence to standard Java conventions, the static keyword and the opening brace { should be on the same line.

  static {
    json = new JSON();
  }

@AdyenAutomationBot AdyenAutomationBot force-pushed the sdk-automation/sessionauthentication branch 3 times, most recently from 7320678 to f8a1cef Compare January 8, 2026 12:04
@AdyenAutomationBot AdyenAutomationBot force-pushed the sdk-automation/sessionauthentication branch from 975ddf3 to 261a5a6 Compare January 8, 2026 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants