-
Notifications
You must be signed in to change notification settings - Fork 144
[transfers] Code generation: update services and models #1652
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Summary of ChangesHello @AdyenAutomationBot, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request contains automated updates to the generated Java models and services for the Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request introduces a number of changes to the generated models, primarily related to formatting and code style. While most of these are minor, I've identified a few patterns that could be improved for better code quality and maintainability. My comments focus on these patterns, which seem to originate from the generator templates. Specifically, I've noted unnecessary trailing semicolons in equals methods, single-line hashCode methods for classes with many fields which harms readability, and significant code duplication in the oneOf deserialization logic. Addressing these in the generator templates would improve the quality of the generated code across the board.
src/main/java/com/adyen/model/transfers/AULocalAccountIdentification.java
Outdated
Show resolved
Hide resolved
src/main/java/com/adyen/model/transfers/BankAccountV3AccountIdentification.java
Outdated
Show resolved
Hide resolved
520e7d8 to
23ebc68
Compare
1e00504 to
ca769d3
Compare
This PR contains the automated changes for the
transfersservice.The commit history of this PR reflects the
adyen-openapicommits that have been applied.