Skip to content

[ECP-9489] Implement PHPStan and fix relevant issues#2843

Merged
candemiralp merged 84 commits intodevelop-10from
ECP-9489
May 13, 2025
Merged

[ECP-9489] Implement PHPStan and fix relevant issues#2843
candemiralp merged 84 commits intodevelop-10from
ECP-9489

Conversation

@candemiralp
Copy link
Contributor

@candemiralp candemiralp commented Jan 3, 2025

Description

This PR implements automated PHPStan analysis as a part of the workflows. As Magento 2 has its own limitations, we have decided to use bitexpert/phpstan-magento extension to provide platform specific requirements.

Besides implementing PHPStan to the workflows, major issues having Level 0 severity have been fixed. Mainly,

  • Repositories have been used to load & save entities instead of the entity class' themselves.
  • Dynamic property declarations have been refactored.
  • Unit tests have been updated.

Tested scenarios

  • Test workflows
  • All payment flows including partial payments
  • All modification flows including partial payments

@candemiralp candemiralp merged commit b25302e into develop-10 May 13, 2025
8 of 14 checks passed
@candemiralp candemiralp deleted the ECP-9489 branch May 13, 2025 08:23
@khushboo-singhvi khushboo-singhvi added Breaking change Indicates a change that has caused a major version update Feature Indicates a new feature addition labels Jul 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Breaking change Indicates a change that has caused a major version update Feature Indicates a new feature addition

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants