Fix error on empty paymentMethodsResponse#2844
Merged
candemiralp merged 3 commits intoAdyen:mainfrom Feb 5, 2025
Merged
Conversation
aschrammel
force-pushed
the
bugfix/check-payment-method-response-before-using
branch
from
3cda078 to
d13c568
Compare
candemiralp
approved these changes
Feb 5, 2025
khushboo-singhvi
approved these changes
Feb 5, 2025
Contributor
|
Hello @aschrammel, Thank you for your contribution. This PR will be merged and released on the next release. Best Regards, |
aschrammel
deleted the
bugfix/check-payment-method-response-before-using
branch
candemiralp
added a commit
that referenced
this pull request
Feb 12, 2025
* Solving the hidden dependency on Magento_Paypal module * Solving the Paypal module dependency * Updating unit test * Updating unit test * Updating unit test * [ECP-9605] Replace union return types with single return types * [ECP-9605] Downgrade Instant Purchase module dependency * [EPC-9605] Update return type * [ECP-9605] Update return type * chore(release): bump to 9.14.1 * Fix error on empty paymentMethodsResponse (#2844) Co-authored-by: Can Demiralp <ecandemiralp@gmail.com> * [EPC-9612] Migrate to CodeQL action v3 and introduce a config file (#2880) Co-authored-by: Can Demiralp <can.demiralp@adyen.com> --------- Co-authored-by: khushboos <khushboo.singhvi@adyen.com> Co-authored-by: Can Demiralp <can.demiralp@adyen.com> Co-authored-by: khushboo-singhvi <7098889+khushboo-singhvi@users.noreply.github.com> Co-authored-by: Andreas Schrammel <andreas@schrammel.codes>
candemiralp
added a commit
that referenced
this pull request
Feb 13, 2025
* Solving the hidden dependency on Magento_Paypal module * Solving the Paypal module dependency * Updating unit test * Updating unit test * Updating unit test * [ECP-9605] Replace union return types with single return types * [ECP-9605] Downgrade Instant Purchase module dependency * [EPC-9605] Update return type * [ECP-9605] Update return type * chore(release): bump to 9.14.1 * Fix error on empty paymentMethodsResponse (#2844) Co-authored-by: Can Demiralp <ecandemiralp@gmail.com> * [EPC-9017] Bump Adyen Web library version to 6.8.0 * [EPC-9017] Remove leftover CSS rules * [EPC-9017] Remove unused imports * [EPC-9017] Implement generic component * [EPC-9017] Implement payment components V6 * [EPC-9017] Remove unnecessary comma * [EPC-9017] Implement the new component for action container * [EPC-9017] Implement new checkout for multishipping * [EPC-9017] Update unit tests --------- Co-authored-by: khushboos <khushboo.singhvi@adyen.com> Co-authored-by: Can Demiralp <can.demiralp@adyen.com> Co-authored-by: khushboo-singhvi <7098889+khushboo-singhvi@users.noreply.github.com> Co-authored-by: Andreas Schrammel <andreas@schrammel.codes>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
In case a merchant has not configured any payment method in the customer area yet, we are facing following issue during checkout:
This results in an endless loading spinner not loading the checkout correctly.
The proposed changes verify that
paymentMethodsResponose.paymentMethodsResponseis set before trying to retrievepaymentMethodsfrom it.Fixes #2631