Skip to content

[ECP-9480] Fix cc_type value for Cartes Bancaires #2847

Merged
khushboo-singhvi merged 5 commits intomainfrom
ECP-9480
Jan 15, 2025
Merged

[ECP-9480] Fix cc_type value for Cartes Bancaires #2847
khushboo-singhvi merged 5 commits intomainfrom
ECP-9480

Conversation

@khushboo-singhvi
Copy link
Contributor

@khushboo-singhvi khushboo-singhvi commented Jan 9, 2025 •
edited by sena1482
Loading

Description
For Cartes Bancaires, the plugin now correctly adds the cc_type value to the sales_order_payment table. Previously, the cc_type for payments with Cartes Bancaires and co-branded Cartes Bancaires payments were set to null.

Tested scenarios

  • Correct value is added with a normal Cartes Bancaires payment
  • Correct value is added with a co-branded Cartes Bancaires payment
  • Correct value is added for other redirect payment mehtods

@khushboo-singhvi khushboo-singhvi requested a review from a team as a code owner January 9, 2025 10:21
candemiralp
candemiralp reviewed Jan 9, 2025
View reviewed changes
@khushboo-singhvi khushboo-singhvi changed the title Setting cc_type value for Carte Bancaire [ECP-8779] Setting cc_type value for Carte Bancaire Jan 9, 2025
@khushboo-singhvi khushboo-singhvi changed the title [ECP-8779] Setting cc_type value for Carte Bancaire [ECP-9480] Setting cc_type value for Carte Bancaire Jan 9, 2025
@sonarqubecloud
Copy link

sonarqubecloud bot commented Jan 15, 2025

Please retry analysis of this Pull-Request directly on SonarQube Cloud

@sonarqubecloud
Copy link

sonarqubecloud bot commented Jan 15, 2025

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
83.3% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@khushboo-singhvi khushboo-singhvi merged commit d736b5d into main Jan 15, 2025
14 of 15 checks passed
@AdyenAutomationBot AdyenAutomationBot mentioned this pull request Jan 15, 2025
Merged
@khushboo-singhvi khushboo-singhvi added the Fix Indicates a bug fix label Jan 15, 2025
@sena1482 sena1482 changed the title [ECP-9480] Setting cc_type value for Carte Bancaire [ECP-9480] Fix cc_type value for Cartes Bancaires Jan 20, 2025
@khushboo-singhvi khushboo-singhvi deleted the ECP-9480 branch February 12, 2025 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@candemiralp candemiralp candemiralp approved these changes

@SushmitaThakur SushmitaThakur SushmitaThakur approved these changes

Assignees

No one assigned

Labels

Fix Indicates a bug fix

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@khushboo-singhvi @candemiralp @SushmitaThakur