[ECP-9481] Clean up leftover code related to cancellations#2852
Merged
candemiralp merged 2 commits intomainfrom Jan 28, 2025
Merged
[ECP-9481] Clean up leftover code related to cancellations#2852candemiralp merged 2 commits intomainfrom
candemiralp merged 2 commits intomainfrom
Conversation
khushboo-singhvi
temporarily deployed
to
internal
GitHub Actions
Inactive
khushboo-singhvi
temporarily deployed
to
internal
GitHub Actions
Inactive
khushboo-singhvi
temporarily deployed
to
internal
GitHub Actions
Inactive
khushboo-singhvi
temporarily deployed
to
internal
GitHub Actions
Inactive
khushboo-singhvi
temporarily deployed
to
internal
GitHub Actions
Inactive
khushboo-singhvi
temporarily deployed
to
internal
GitHub Actions
Inactive
candemiralp
approved these changes
Jan 20, 2025
|
Merged
sena1482
changed the title
khushboo-singhvi
added
Fix
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
On v9 and later, the plugin has a new order cancellation flow that depends on the
/payments/detailsresponse. When the response includes and error, the plugin cancels the order. When no error occurs, it waits for the OFFER_CLOSED webhook. We removed some leftover front end code that is not relevant for the new flow.Fixes