[ECP-9542] Solving the hidden dependency on Magento_Paypal module#2855
Merged
khushboo-singhvi merged 8 commits intomainfrom Feb 4, 2025
Merged
[ECP-9542] Solving the hidden dependency on Magento_Paypal module#2855khushboo-singhvi merged 8 commits intomainfrom
khushboo-singhvi merged 8 commits intomainfrom
Conversation
khushboo-singhvi
temporarily deployed
to
internal
GitHub Actions
Inactive
khushboo-singhvi
temporarily deployed
to
internal
GitHub Actions
Inactive
khushboo-singhvi
temporarily deployed
to
internal
GitHub Actions
Inactive
khushboo-singhvi
temporarily deployed
to
internal
GitHub Actions
Inactive
khushboo-singhvi
temporarily deployed
to
internal
GitHub Actions
Inactive
khushboo-singhvi
temporarily deployed
to
internal
GitHub Actions
Inactive
|
|
Please retry analysis of this Pull-Request directly on SonarQube Cloud |
khushboo-singhvi
temporarily deployed
to
internal
GitHub Actions
Inactive
khushboo-singhvi
temporarily deployed
to
internal
GitHub Actions
Inactive
khushboo-singhvi
temporarily deployed
to
internal
GitHub Actions
Inactive
khushboo-singhvi
temporarily deployed
to
internal
GitHub Actions
Inactive
khushboo-singhvi
temporarily deployed
to
internal
GitHub Actions
Inactive
khushboo-singhvi
temporarily deployed
to
internal
GitHub Actions
Inactive
khushboo-singhvi
temporarily deployed
to
internal
GitHub Actions
Inactive
khushboo-singhvi
temporarily deployed
to
internal
GitHub Actions
Inactive
khushboo-singhvi
temporarily deployed
to
internal
GitHub Actions
Inactive
khushboo-singhvi
temporarily deployed
to
internal
GitHub Actions
Inactive
khushboo-singhvi
temporarily deployed
to
internal
GitHub Actions
Inactive
khushboo-singhvi
temporarily deployed
to
internal
GitHub Actions
Inactive
khushboo-singhvi
temporarily deployed
to
internal
GitHub Actions
Inactive
khushboo-singhvi
temporarily deployed
to
internal
GitHub Actions
Inactive
khushboo-singhvi
temporarily deployed
to
internal
GitHub Actions
Inactive
khushboo-singhvi
temporarily deployed
to
internal
GitHub Actions
Inactive
khushboo-singhvi
temporarily deployed
to
internal
GitHub Actions
Inactive
khushboo-singhvi
temporarily deployed
to
internal
GitHub Actions
Inactive
khushboo-singhvi
temporarily deployed
to
internal
GitHub Actions
Inactive
khushboo-singhvi
temporarily deployed
to
internal
GitHub Actions
Inactive
khushboo-singhvi
temporarily deployed
to
internal
GitHub Actions
Inactive
khushboo-singhvi
temporarily deployed
to
internal
GitHub Actions
Inactive
khushboo-singhvi
temporarily deployed
to
internal
GitHub Actions
Inactive
zenit2001
approved these changes
Feb 4, 2025
candemiralp
approved these changes
Feb 4, 2025
khushboo-singhvi
temporarily deployed
to
internal
GitHub Actions
Inactive
khushboo-singhvi
temporarily deployed
to
internal
GitHub Actions
Inactive
khushboo-singhvi
temporarily deployed
to
internal
GitHub Actions
Inactive
khushboo-singhvi
temporarily deployed
to
internal
GitHub Actions
Inactive
khushboo-singhvi
temporarily deployed
to
internal
GitHub Actions
Inactive
khushboo-singhvi
temporarily deployed
to
internal
GitHub Actions
Inactive
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
It looks like the module has a hidden dependency on Magento_Paypal module. If this module is disabled, our frontend can't find the value of global configuration window.checkoutConfig.payment.iframe. This results in card component not being able to load correctly.
This PR aims to solve the hidden dependency on Magento_Paypal module by using default magento's functionality
Tested scenarios
Successful loading of card component after disabling the Magento Paypal module.
Fixes