[ECP-9078] Implement is_open_invoice payment method configuration field#2856
Merged
candemiralp merged 14 commits intomainfrom Feb 18, 2025
Merged
[ECP-9078] Implement is_open_invoice payment method configuration field#2856candemiralp merged 14 commits intomainfrom
candemiralp merged 14 commits intomainfrom
Conversation
|
|
acampos1916
requested changes
Feb 18, 2025
acampos1916
approved these changes
Feb 18, 2025
khushboo-singhvi
approved these changes
Feb 18, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The plugin uses a hardcoded list of tx_variants to identify open invoice payment methods. However, this approach is not scalable and not adhering the usage of separate payment methods. This PR implements a new payment method configuration field to determine whether if the payment method is open invoice or not.
This implementation now checks the configuration property
is_open_invoiceinconfig.xmlinstead of the hardcoded values.Tested scenarios