[ECP-9582] Remove union return type to fix compatibility issue on Magento 2.4.4 and 2.4.5

[candemiralp]

Description

We previously introduced a union return type to DownloadApplePayDomainAssociationFile class that broke the compatibility of the plugin with Magento 2.4.4 and 2.4.5, although it is supported with PHP 8. The union return type is now removed from this class.

Tested scenarios

• Downloading Apple Pay domain association file

Fixes #2842

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[aschrammel]

@candemiralp Just FYI: We faced similar problems in the past on the union return type in \Adyen\Payment\Model\OrderRepository::getOrderByQuoteId.

[candemiralp]

Hello @aschrammel,

Thank you for the heads-up! Do you get an issue while running bin/magento di:compile command? Could you please share your Magento, PHP and plugin versions?

Best Regards,
Can

[aschrammel]

Hi @candemiralp

As said we received that error in the past on bin/magento setup:die:compile.
Can't say for sure how it is now, as we patched it on our end, removing the union type.

Not sure on which versions we've been, when it happened. Can give it a try, when I'm back if it still happens.

[candemiralp]

Hello @aschrammel,

Thank you for the explanation. I've tried compiling the generated files on Magento 2.4.4 and PHP 8.2 without being able to reproduce the issue. Please let us know if the issue is persistent on your end.

Best Regards,
Can

[aschrammel]

Good morning @candemiralp,

Sorry for the late reply. Seems to be fine on our end as well now.

Best regards
Andreas