[ECP-8375] Fix invoicing for cases where base currency is used as the charged_currency#2860
Merged
candemiralp merged 2 commits intomainfrom Jan 28, 2025
Merged
[ECP-8375] Fix invoicing for cases where base currency is used as the charged_currency#2860candemiralp merged 2 commits intomainfrom
charged_currency#2860candemiralp merged 2 commits intomainfrom
Conversation
candemiralp
changed the title
khushboo-singhvi
approved these changes
Jan 23, 2025
|
Merged
sena1482
changed the title
charged_currencyy
sena1482
changed the title
charged_currencyycharged_currency
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The plugin is using
isFullInvoiceAmountManuallyCaptured()to determine if the full amount is captured or not. This bug affects the comparison if the plugin usesbasecurrency as thecharged_currency.This fix implements the usage of
AdyenAmountCurrencyclass for the invoice amounts, which checks the configuration to determine thecharged_currencybefore usinggetGrandTotal()orgetBaseGrandTotal().Tested scenarios
Fixes #1955