[ECP-9562] Fix the quote staying active on authorised payments#2921
Merged
candemiralp merged 5 commits intomainfrom Apr 4, 2025
Merged
[ECP-9562] Fix the quote staying active on authorised payments#2921candemiralp merged 5 commits intomainfrom
candemiralp merged 5 commits intomainfrom
Conversation
|
khushboo-singhvi
approved these changes
Apr 3, 2025
|
Please retry analysis of this Pull-Request directly on SonarQube Cloud |
amihajlovski
approved these changes
Apr 3, 2025
|
Please retry analysis of this Pull-Request directly on SonarQube Cloud |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Under some edge cases, the plugin might skip
/payments/detailscall from the frontend but Adyen is notified by the PSP externally. After the payment is authorised, theAuthorisationwebhook is sent to the store and order state is updated correctly. However, this flow doesn't deactivate the quote, which might cause some issues in the downstream operations.This PR implements a logic to disable the quote while processing
Authorisationwebhook if it is still active.Tested scenarios
/payments/detailscall