[EPC-9586] Fix card form validation after payment method switching#2943
Merged
candemiralp merged 3 commits intomainfrom Apr 30, 2025
Merged
[EPC-9586] Fix card form validation after payment method switching#2943candemiralp merged 3 commits intomainfrom
candemiralp merged 3 commits intomainfrom
Conversation
khushboo-singhvi
approved these changes
Apr 22, 2025
amihajlovski
approved these changes
Apr 22, 2025
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Description
The card component mount function is triggered again after re-selecting card payment method even though the card component is mounted in the first attempt. This action invalidates the
isValidproperty of the card component andvalidate()function fails. Therefore,Place Orderbutton stays deactivated. This PR checks the existences of the card component before triggeringmountaction.Besides this issue, multishipping card payment has a similar issue in which
stateDatainput field couldn't be populated again after re-selecting the card payment method. This issue occurs as the stateData is only assigned ononChangeevent callback. However, while switching the payment method,onChangecallback is not triggered. This PR also addresses this issue in the multipshipping method renderer.While handling this issue, more tests have been performed on alternative payment method with forms (SEPA Direct Debit etc.) and no issues have been observed.
Tested scenarios
Fixes #2898