[ECP-9665] Fix RefundDataBuilderTest to solve marketplace submission issue#2955
Merged
khushboo-singhvi merged 7 commits intomainfrom May 6, 2025
Merged
[ECP-9665] Fix RefundDataBuilderTest to solve marketplace submission issue#2955khushboo-singhvi merged 7 commits intomainfrom
khushboo-singhvi merged 7 commits intomainfrom
Conversation
|
amihajlovski
approved these changes
May 6, 2025
candemiralp
approved these changes
May 6, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
RefundDataBuilderTest has a mock which extends PSP's ArrayObject class. However, this class is restricted on Magento's codesniffing rules.
Although, this error has been suppressed by phpcs:ignore inline comment as it is only related to the tests. However, it became a blocker on the Magento Marketplace submission due to the same error message.
Tested scenarios
Fixes