[ECP-9320] Refactor Data Helper#2966
Merged
khushboo-singhvi merged 26 commits intodevelop-10from May 28, 2025
Merged
Conversation
* [ECP-9566] Refactor Donations * [ECP-9566] Updating unit test * [ECP-9566] setting base url for APS ajax calls
# Conflicts: # Test/Unit/Model/Api/AdyenDonationCampaignsTest.php
candemiralp
previously approved these changes
May 28, 2025
|
candemiralp
approved these changes
May 28, 2025
khushboo-singhvi
added
the
Breaking change
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Data helper has a lot of pieces of code which can be moved to other related places within the module.
This PR aims at simplifying the Data Helper and updating the related unit tests.
Tested scenarios
Fixes