Conversation
* [ECP-9745] Update the DB schema and refactor related classes * [ECP-9745] Update argument type declarations * [ECP-9745] Update example event handlers * [ECP-9745] Fix model argument
* [ECP-9751] Implement a cronjob to submit pending events * [ECP-9751] Enable main workflow on the feature branch * [ECP-9751] Write unit tests * [ECP-9751] Update tests
* [ECP-9417] Implement analytics event dispatchers * [ECP-9417] Add try-catch block
#3114) * [ECP-9727] Implement an event dispatcher for plugin installation event * [ECP-9727] Add missing module setup end flag
…3138) * [ECP-9835] Add version field to the dbschema and entity definition * [ECP-9835] Dispatch events only for Adyen namespace * [ECP-9835] Group entities by version and submit them separately * [ECP-9835] Put the feature behind a config flag * Update SubmitAnalyticsEvents.php
Summary of ChangesHello @candemiralp, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request introduces a comprehensive reliability data collection mechanism for the Adyen Payment module. Its primary purpose is to enhance the module's stability and performance by systematically tracking key operational events, including API interactions and controller dispatches. This data is then processed and securely transmitted to Adyen for in-depth analysis, providing valuable insights into the module's behavior in real-world scenarios. Merchants retain full control over this feature, with an explicit option to enable or disable data collection. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Ignored Files
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces a comprehensive reliability and analytics tracking feature. The implementation is generally solid, leveraging modern PHP features and following good design patterns for event tracking, processing, and retries. I've identified a critical bug in the analytics event collection query that could prevent events from being processed correctly. Additionally, there are several areas for improvement regarding code style, test correctness, and configuration, for which I've provided specific suggestions. Addressing these points will enhance the robustness and maintainability of this new feature.
* Optimize rest events to intercept * Write unit tests * Enable workflows * Fix static code issues
* Implement clean up functionality * Prevent the duplicate db query
candemiralp
dismissed stale reviews from shubhamk67 and khushboo-singhvi
via
5f04efe
|
3 participants
Reliability Tracking Framework is a built-in feature of the plugin where the SLOs of the critical payment flows can be measured by calculating the ratio of the number of successful relevant events. As a part of this initiative, the following actions are being tracked if the feature is enabled.
Note that, this feature is disabled by default and can be enabled by setting
Collect and submit application reliability datafield toYesunderTesting and performancesection of the configuration block.This framework collects the events for the above mentioned actions and submits to Adyen every minute. The framework is especially useful for Adyen's operational team's to proactively monitor the health of merchants' instances and for the development team to measure the quality of the releases.
There is no payment data or PII collected for the desired purpose.
The plugin only sends the state of the tracked event name together with the timestamp.