[ECP-9641] Fix incorrect payment method filtering on virtual quote payments

[candemiralp]

Description

This PR refactors the payment method sorting and filtering functionality to fetch the correct payment methods on virtual quotes.

[gemini-code-assist]

Summary of Changes

Hello @candemiralp, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses an issue where payment methods were incorrectly filtered for virtual quote payments. It achieves this by refactoring the way Adyen payment methods are retrieved and cached, ensuring consistent and accurate filtering across different checkout flows, including multishipping and standard checkout processes. The changes centralize the API call for payment methods and apply the filtering logic more broadly through a new plugin.

Highlights

• Refactored Payment Method Fetching: The logic for fetching Adyen payment methods has been centralized into a new getApiResponse method within the PaymentMethods helper, which now includes in-memory caching to prevent redundant API calls.
• Improved Payment Method Filtering for Virtual Quotes: A new plugin, SortAndFilterAdyenPaymentMethods, has been introduced to correctly apply Adyen payment method filtering to virtual quote payments by intercepting Magento\Quote\Api\PaymentMethodManagementInterface::getList.
• Dependency Updates and Constructor Refinements: Several helper and plugin classes have had their constructors updated to utilize PHP 8.1's readonly properties and to reflect the new centralized PaymentMethods helper for API responses, streamlining dependencies.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request introduces a significant refactoring of how Adyen payment methods are fetched and filtered within the Magento module. A new PaymentMethods::getApiResponse() method is added to centralize the fetching of Adyen payment methods from the API, incorporating an in-memory caching mechanism to prevent redundant API calls. The RequestInterface dependency is moved from PaymentMethodsFilter to PaymentMethods to facilitate this. Consequently, the MagentoPaymentDetails helper and MultishippingPaymentMethods plugin are updated to utilize this new getApiResponse() method directly, simplifying their logic and removing the direct dependency on PaymentMethodsFilter for fetching the raw API response. A new plugin, SortAndFilterAdyenPaymentMethods, is introduced to apply the payment method filtering logic to Magento\Quote\Api\PaymentMethodManagementInterface::getList, ensuring consistent filtering across different checkout flows. Constructor dependencies across several classes are updated to use PHP 8.1+ promoted properties, and relevant unit tests are added or modified to reflect these architectural changes and ensure the new caching and filtering logic functions correctly.

[sonarqubecloud]

Quality Gate passed

Issues
2 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud