Ecp 9882 v9

[candemiralp]

Description

Tested scenarios

Fixes

[gemini-code-assist]

Summary of Changes

Hello @candemiralp, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request delivers a significant update to the Adyen payment module, focusing on improving the reliability and functionality of payment processing. It includes crucial updates to development and CI environments, refines core payment logic for various scenarios, and expands the range of supported payment methods. The changes also introduce a new GraphQL endpoint for POS payments and enhance the user experience with more dynamic and robust frontend components, alongside general code quality and error handling improvements.

Highlights

• Docker and CI Configuration Updates: The Dockerfile now includes libicu-dev for enhanced internationalization support, and the e2e Docker Compose configuration has been streamlined by removing an unnecessary test report volume. The main Docker Compose file updates OpenSearch to opensearchproject/opensearch:2, removes an unused port, and adds security and Java options.
• Payment Logic Refinements and Error Handling: Payment processing has been made more robust with applicationInfo being built earlier in the request, and the removal of strict tax amount validation for L2/L3 data. Combo card logic for installments has been refined, especially for Brazilian debit cards. Error handling in the checkout response validator now collects error codes for more graceful processing instead of immediately throwing exceptions, supported by a new error mapping XML.
• New Payment Methods and GraphQL Integration: The module introduces support for new payment methods: Scalapay (3x and 4x installments) and PayNow. Additionally, a new GraphQL resolver (InitiatePosPayment) has been added to facilitate initiating Point-of-Sale payments.
• Frontend and UI/UX Improvements: Frontend components have been updated to better handle virtual quotes by loading payment methods and connected terminals via a new config provider. Stored card validation and installment initialization logic have been improved, and the admin configuration wizard now correctly manages the readonly state of API key fields. Payment method components now rebuild dynamically when the grand total changes.
• Webhook Processing and Logging Enhancements: The authorization webhook handler has been refactored into smaller, more manageable private methods, improving readability and maintainability. Quote deactivation logic has been made more resilient, and logging has been enhanced to filter sensitive data more effectively while allowing specific whitelisted keys like uniqueTerminalIds.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Ignored Files

• Ignored by pattern: .github/workflows/** (6)
  • .github/workflows/create-release.yml
  • .github/workflows/e2e-test.yml
  • .github/workflows/graphql-test.yml
  • .github/workflows/main.yml
  • .github/workflows/mftf-test.yml
  • .github/workflows/restapi-test.yml

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request introduces an in-memory caching mechanism for connected terminals by adding a connectedTerminalsApiResponse property and associated getter/setter methods to Helper/ConnectedTerminals.php. Existing calls in Block/Form/PosCloud.php and Helper/MagentoPaymentDetails.php are updated to utilize this new cached method. Furthermore, a new AdyenVirtualQuoteConfigProvider is added to provide payment methods and connected terminals for virtual quotes, bypassing standard API calls, with corresponding JavaScript updates in view/frontend/web/js/model/adyen-configuration.js and view/frontend/web/js/view/payment/adyen-methods.js to consume this data. The review comment identifies a critical bug in the new AdyenVirtualQuoteConfigProvider, noting that the getApiResponse() method called on the PaymentMethods helper does not exist and should be replaced with getPaymentMethods() using the quote ID.

[gemini-code-assist]

The code is attempting to call getApiResponse() on the Adyen\Payment\Helper\PaymentMethods helper, but this method does not exist in that class. This will cause a fatal error. It seems you intended to call getPaymentMethods(), which requires the quote ID. Please correct the method call.

                    $this->paymentMethodsHelper->getPaymentMethods($this->session->getQuote()->getId());