[ECP-9882-v9] Allow using public_hash on recurring graphql payments

[candemiralp]

Description

This PR fixes the missing implementation for facilitating recurring GraphQL payments with public_hash of the vault payment token.

A recurring payment now can be completed via providing the vault payment method and corresponding public_hash in the additional data of the setPaymentMethodOnCart mutation.

Tested scenarios

• GraphQL headless recurring payments using public_hash value

[gemini-code-assist]

Summary of Changes

Hello @candemiralp, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses a missing implementation that prevented recurring GraphQL payments from utilizing the public_hash of vaulted payment tokens. By introducing the public_hash field into the GraphQL input types and payment data assignment observers, it now allows for seamless recurring payments through the setPaymentMethodOnCart mutation using a previously stored payment method's public_hash.

Highlights

• GraphQL Recurring Payments: This pull request enables the use of public_hash for facilitating recurring GraphQL payments, allowing customers to complete transactions using vaulted payment tokens.
• Payment Data Assignment: The public_hash field has been added to the list of allowed additional data fields in both AdyenCcDataAssignObserver and AdyenPaymentMethodDataAssignObserver to ensure it is correctly processed during payment method assignment.
• GraphQL Schema and DI Configuration: The GraphQL schema (etc/schema.graphqls) has been updated to include public_hash as an optional input field for AdyenAdditionalDataCc and AdyenAdditionalData. Additionally, etc/graphql/di.xml now includes mappings for various vaulted payment methods to their respective AdditionalDataProvider classes, ensuring proper handling of vaulted payment data.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request enables recurring payments with public_hash for GraphQL, which is a great feature enhancement. The changes correctly update the GraphQL schema to include the public_hash field and make stateData optional, which is necessary for vaulted payments. The data assign observers are also correctly updated to allow the new field. I've included one suggestion to improve the maintainability of the di.xml configuration file by sorting the newly added payment method providers.

[gemini-code-assist]

For better readability and maintainability, it would be beneficial to sort these new <item> entries alphabetically by their name attribute. This will make it easier to locate specific payment methods in the future as the list grows.

                <item name="adyen_ach_vault" xsi:type="object">Adyen\Payment\Model\Cart\Payment\AdditionalDataProvider\AdyenPm</item>
                <item name="adyen_amazonpay_vault" xsi:type="object">Adyen\Payment\Model\Cart\Payment\AdditionalDataProvider\AdyenPm</item>
                <item name="adyen_applepay_vault" xsi:type="object">Adyen\Payment\Model\Cart\Payment\AdditionalDataProvider\AdyenPm</item>
                <item name="adyen_bcmc_mobile_vault" xsi:type="object">Adyen\Payment\Model\Cart\Payment\AdditionalDataProvider\AdyenPm</item>
                <item name="adyen_bcmc_vault" xsi:type="object">Adyen\Payment\Model\Cart\Payment\AdditionalDataProvider\AdyenPm</item>
                <item name="adyen_carnet_vault" xsi:type="object">Adyen\Payment\Model\Cart\Payment\AdditionalDataProvider\AdyenPm</item>
                <item name="adyen_cashapp_vault" xsi:type="object">Adyen\Payment\Model\Cart\Payment\AdditionalDataProvider\AdyenPm</item>
                <item name="adyen_cc_vault" xsi:type="object">Adyen\Payment\Model\Cart\Payment\AdditionalDataProvider\AdyenCc</item>
                <item name="adyen_dana_vault" xsi:type="object">Adyen\Payment\Model\Cart\Payment\AdditionalDataProvider\AdyenPm</item>
                <item name="adyen_directEbanking_vault" xsi:type="object">Adyen\Payment\Model\Cart\Payment\AdditionalDataProvider\AdyenPm</item>
                <item name="adyen_eps_vault" xsi:type="object">Adyen\Payment\Model\Cart\Payment\AdditionalDataProvider\AdyenPm</item>
                <item name="adyen_gcash_vault" xsi:type="object">Adyen\Payment\Model\Cart\Payment\AdditionalDataProvider\AdyenPm</item>
                <item name="adyen_giropay_vault" xsi:type="object">Adyen\Payment\Model\Cart\Payment\AdditionalDataProvider\AdyenPm</item>
                <item name="adyen_googlepay_vault" xsi:type="object">Adyen\Payment\Model\Cart\Payment\AdditionalDataProvider\AdyenPm</item>
                <item name="adyen_ideal_vault" xsi:type="object">Adyen\Payment\Model\Cart\Payment\AdditionalDataProvider\AdyenPm</item>
                <item name="adyen_kakaopay_vault" xsi:type="object">Adyen\Payment\Model\Cart\Payment\AdditionalDataProvider\AdyenPm</item>
                <item name="adyen_klarna_account_vault" xsi:type="object">Adyen\Payment\Model\Cart\Payment\AdditionalDataProvider\AdyenPm</item>
                <item name="adyen_klarna_paynow_vault" xsi:type="object">Adyen\Payment\Model\Cart\Payment\AdditionalDataProvider\AdyenPm</item>
                <item name="adyen_klarna_vault" xsi:type="object">Adyen\Payment\Model\Cart\Payment\AdditionalDataProvider\AdyenPm</item>
                <item name="adyen_momo_wallet_vault" xsi:type="object">Adyen\Payment\Model\Cart\Payment\AdditionalDataProvider\AdyenPm</item>
                <item name="adyen_paybybank_ais_dd_vault" xsi:type="object">Adyen\Payment\Model\Cart\Payment\AdditionalDataProvider\AdyenPm</item>
                <item name="adyen_paybybank_vault" xsi:type="object">Adyen\Payment\Model\Cart\Payment\AdditionalDataProvider\AdyenPm</item>
                <item name="adyen_paypal_vault" xsi:type="object">Adyen\Payment\Model\Cart\Payment\AdditionalDataProvider\AdyenPm</item>
                <item name="adyen_sepadirectdebit_vault" xsi:type="object">Adyen\Payment\Model\Cart\Payment\AdditionalDataProvider\AdyenPm</item>
                <item name="adyen_trustly_vault" xsi:type="object">Adyen\Payment\Model\Cart\Payment\AdditionalDataProvider\AdyenPm</item>
                <item name="adyen_twint_vault" xsi:type="object">Adyen\Payment\Model\Cart\Payment\AdditionalDataProvider\AdyenPm</item>
                <item name="adyen_zip_vault" xsi:type="object">Adyen\Payment\Model\Cart\Payment\AdditionalDataProvider\AdyenPm</item>

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud