[ECP-9722] Card vault payments API functional tests

[candemiralp]

Description

This PR implements new API functional test cases covering card vault payments.

Tested scenarios

• Automated testing workflow

[gemini-code-assist]

Summary of Changes

Hello @candemiralp, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request adds a comprehensive functional test for the Adyen payment module, specifically focusing on recurring card vault payments through the GraphQL API. The test simulates a customer's journey from an initial purchase where their card details are securely vaulted, to a subsequent purchase where the stored card token is used for payment. This ensures the reliability and correct functionality of the card vaulting and recurring payment process within the Magento GraphQL environment.

Highlights

• New Functional Test: Introduced a new functional test file, AdyenRecurringTest.php, to validate card vault payments via the GraphQL API.
• End-to-End Vaulting Scenario: The test covers the complete flow of vaulting a credit card during an initial order and then utilizing the stored token for a subsequent order.
• GraphQL API Coverage: The test extensively uses GraphQL mutations and queries for cart creation, product addition, address and shipping method setup, and order placement, ensuring robust API coverage for this payment flow.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request introduces a new GraphQL functional test for card vault payments. The test covers generating a card token and then using it to make a subsequent payment. My review has identified a critical issue with how the vault payment is constructed, a high-severity issue with a leftover debugging statement, and a medium-severity suggestion to improve the test's maintainability by refactoring repeated code.

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud