[ECP-9487] Handle exceptions in AdyenLogger getInvoiceContext#3220
[ECP-9487] Handle exceptions in AdyenLogger getInvoiceContext#3220shubhamk67 merged 3 commits intomainfrom
Conversation
Summary of ChangesHello @shubhamk67, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request enhances the robustness of the Adyen logging mechanism by introducing exception handling to the Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request effectively prevents exceptions within AdyenLogger::getInvoiceContext from halting webhook processing by wrapping the logic in a try-catch block and returning an empty context on failure. This is a good improvement for robustness. My review includes a suggestion to log the caught exception to improve observability and make debugging easier, as silently swallowing exceptions can hide underlying issues.
Logger/AdyenLogger.php
Outdated
| } catch (\Exception $e) { | ||
| return []; | ||
| } |
There was a problem hiding this comment.
While catching the exception is a good step to prevent process interruption, it's also important to log that an exception occurred. Swallowing the exception silently can make it difficult to debug issues with logging context in the future. I suggest logging the exception message as a warning before returning the empty array.
} catch (\Exception $e) {
$this->addAdyenWarning('Failed to generate invoice context for logging: ' . $e->getMessage());
return [];
}
|


Description
This PR adds exception handling in AdyenLogger.getInvoiceContext() to allow webhook processing to continue in case of failures during logging by returning an empty context.