[ECP-9848] Fix graphql error message of adyenPaymentDetails mutation

[candemiralp]

Description

adyenPaymentDetails mutation currently returns Internal server error as the thrown exception is not formatted correctly.

In order to fix this issue, AggregateExceptionMessageFormatter has been injected with the required exception formatters.

Tested scenarios

• Unhappy adyenPaymentDetails mutation call

[gemini-code-assist]

Summary of Changes

Hello @candemiralp, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request resolves an issue where the adyenPaymentDetails GraphQL mutation would return a vague 'Internal server error' when exceptions occurred, hindering proper debugging and user feedback. By integrating Magento's robust AggregateExceptionMessageFormatter and configuring it through dependency injection, the system can now deliver precise and actionable error messages, significantly enhancing the reliability and user experience of the Adyen payment GraphQL API.

Highlights

• Improved Error Handling: The adyenPaymentDetails GraphQL mutation now utilizes Magento's AggregateExceptionMessageFormatter to provide more specific and user-friendly error messages, replacing the generic 'Internal server error' previously returned.
• Dependency Injection Update: The GetAdyenPaymentDetails resolver has been updated to inject an instance of AggregateExceptionMessageFormatter for consistent and configurable error message formatting.
• DI Configuration for Adyen GraphQL: A new virtual type, AdyenGraphQlExceptionMessageFormatter, has been defined in di.xml to specifically configure the AggregateExceptionMessageFormatter with standard GraphQL, no-such-entity, and validation message formatters for the Adyen payment module.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request effectively resolves the issue of generic error messages in the adyenPaymentDetails GraphQL mutation by properly handling exceptions. The introduction of AggregateExceptionMessageFormatter through dependency injection is a solid improvement, and it's great to see the removal of direct ObjectManager usage. I've left a couple of minor suggestions for code cleanup and consistency. Overall, this is a good change.

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud