[ECP-9880] Write GraphQl API functional tests for giftcard implementation

[candemiralp]

Description

This PR implements GraphQl API functional tests for giftcard payments.

Following flows have been covered with this implementation.

1. Giftcard balance check
2. Saving, reading and deleting giftcard stateData
3. Single giftcard payments
4. Multiple giftcard payments
5. Partial (card + giftcard) payments

[gemini-code-assist]

Summary of Changes

Hello @candemiralp, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces a new suite of functional tests for the Adyen gift card GraphQL API. These tests validate the core functionalities of checking gift card balances, managing gift card state data within a shopping cart, and querying redeemed gift card details, thereby enhancing the reliability and stability of the gift card integration.

Highlights

• New GraphQL API Functional Tests: Introduced a new test file, AdyenGiftcardTest.php, to provide comprehensive functional testing for Adyen's gift card GraphQL API endpoints.
• Gift Card Balance Check: Added tests for the adyenPaymentMethodsBalance GraphQL query, covering scenarios for successful balance checks and insufficient balance.
• Gift Card State Data Management: Implemented tests for adyenSaveStateData and adyenRemoveStateData GraphQL mutations, ensuring proper saving and removal of gift card state data associated with a cart.
• Redeemed Gift Cards Query: Included tests for the adyenRedeemedGiftcards GraphQL query, verifying the correct retrieval of redeemed gift card information, remaining amount, and total discount for a given cart.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request adds functional tests for the Adyen Giftcard GraphQL API. The tests cover balance checking, saving, retrieving, and removing gift card state data. The test cases are well-structured.

My review includes a few suggestions to improve the test code's quality and maintainability:

• I've recommended using GraphQL variables instead of string interpolation for building queries. This is a best practice that improves security and readability.
• I've also suggested defining constants for recurring 'magic' values to make the tests easier to read and maintain.

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud