[ECP-9894] Remove redundant capture mode check from the Expire webhook handler

[candemiralp]

Description

This PR cleans-up the redundant capture mode check from the handler class. The EXPIRE webhook can not be obtained in case of auto captures. Hence, this check is not necessary.

[gemini-code-assist]

Summary of Changes

Hello @candemiralp, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request refines the ExpireWebhookHandler by removing a redundant conditional check for 'auto capture' mode. Since the 'EXPIRE' webhook is inherently not processed when auto-capture is enabled, the previous check was superfluous. This change simplifies the codebase, removes an unnecessary dependency, and updates the corresponding unit tests to reflect the more accurate and efficient logic.

Highlights

• Redundant Code Removal: Eliminated an unnecessary check for 'auto capture' mode within the ExpireWebhookHandler as the 'EXPIRE' webhook is not relevant in this mode.
• Dependency Cleanup: Removed the Adyen\Payment\Model\Config\Source\CaptureMode import from the handler and its test file, reducing unused dependencies.
• Test Suite Refinement: Updated the unit tests for ExpireWebhookHandler by removing the testAutoCaptureEnabled method and all related getCaptureMode mock expectations, aligning tests with the streamlined logic.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Changelog

• Helper/Webhook/ExpireWebhookHandler.php
  • Removed use Adyen\Payment\Model\Config\Source\CaptureMode; statement.
  • Deleted the conditional block that checked for CaptureMode::CAPTURE_MODE_AUTO and its associated getCaptureMode call.
• Test/Unit/Helper/Webhook/ExpireWebhookHandlerTest.php
  • Removed use Adyen\Payment\Model\Config\Source\CaptureMode; statement.
  • Deleted the testAutoCaptureEnabled unit test method.
  • Removed getCaptureMode mock expectations from testExpireWebhookIgnored, testHandleWebhookWithPartialExpiration, testHandleWebhookWithShipments, and testHandleWebhookSuccessfully methods.

Activity

• The author candemiralp created this pull request to address an issue related to redundant code in the ExpireWebhookHandler.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request removes a redundant check for auto-capture mode from the ExpireWebhookHandler. The change is based on the premise that EXPIRE webhooks are not sent for auto-captured payments, making the existing check and associated logic unnecessary. The corresponding unit tests have been updated to reflect this change by removing the test case for the removed logic and other related mock setups. This cleanup simplifies the code and improves maintainability. The changes are well-contained and look correct.

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud