[ECP-9907-v9] Fix incompatible DB connection pattern in CreateStatusAuthorized class

[candemiralp]

Description

Using the repository pattern is fragile if multi-cluster setup is used. Instead, single DB connection instance approach has been implemented for CreateStatusAuthorized migration class.

[gemini-code-assist]

Summary of Changes

Hello @candemiralp, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses an incompatibility issue with the database connection pattern within the CreateStatusAuthorized data patch, particularly in multi-cluster setups. It refactors the order status creation and assignment logic to directly interact with the database connection, enhancing robustness and ensuring proper handling of existing status entries.

Highlights

• Database Interaction Refactoring: Refactored the CreateStatusAuthorized data patch to use direct database interaction for creating and assigning the 'adyen_authorized' order status.
• Improved Multi-Cluster Compatibility: Removed the reliance on Magento's StatusFactory and StatusResourceFactory repository pattern, which was identified as fragile in multi-cluster environments, by switching to a single DB connection instance approach.
• Idempotent Status Creation: Implemented explicit checks for the existence of the order status and state before insertion, preventing AlreadyExistsException and ensuring idempotent operations during patch application.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Changelog

• Setup/Patch/Data/CreateStatusAuthorized.php
  • Removed StatusFactory, StatusResourceFactory, and AlreadyExistsException dependencies.
  • Replaced the repository pattern for order status creation with direct database SELECT and INSERT operations.
  • Added logic to check if the 'adyen_authorized' status and its state already exist before attempting to insert them into sales_order_status and sales_order_status_state tables.
  • Ensured the startSetup() and endSetup() methods are called on the database connection for proper transaction management.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request refactors the CreateStatusAuthorized data patch to use direct database connections instead of Magento's object models, which is a good change to improve compatibility with multi-cluster environments. The implementation is sound, however I have one suggestion to make the code more concise and efficient.

A critical issue is that the corresponding unit test (Test/Unit/Setup/Patch/Data/CreateStatusAuthorizedTest.php) has not been updated to reflect the constructor changes. This will cause the test suite to fail. Please ensure the tests are updated to align with the new class structure.

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud