[ECP-8385] Implement a datetime picker to Pay by Link

[hossam-adyen]

Description
Updated the Admin Order creation workflow to allow for the inclusion of a specific time when setting an Adyen Pay by Link expiration. Previously, the system was limited to broader date selections; this change provides merchants with more granular control over link validity.

[gemini-code-assist]

Summary of Changes

Hello @hossam-adyen, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces a significant improvement to the Adyen Pay by Link feature by enabling the selection of a specific expiration time. This change provides merchants with greater flexibility and control over the lifespan of payment links, moving beyond the previous date-only limitation. The update involves both front-end UI enhancements and corresponding backend logic adjustments to support the new datetime precision.

Highlights

• Enhanced Expiration Control: The Pay by Link expiration functionality has been upgraded to allow merchants to specify a precise time, in addition to the date, for link validity.
• UI Component Update: The Admin Order creation workflow now utilizes a datetime picker instead of a date-only calendar, providing a more granular selection interface.
• Backend Logic Adjustment: The backend processing of expiration dates has been modified to correctly handle and validate full datetime strings, removing previous hardcoded time components.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Changelog

• Block/Form/PayByLink.php
  • Updated the date format constant used for Pay by Link expiration to include time.
• Gateway/Request/ExpiryDateDataBuilder.php
  • Removed the hardcoded ' 23:59:59' suffix when parsing the expiry date, allowing for specific time input.
• Gateway/Validator/PaymentLinksRequestValidator.php
  • Removed the hardcoded ' 23:59:59' suffix from the expiration time during validation.
• view/adminhtml/templates/form/pay_by_link.phtml
  • Replaced the 'mage/calendar' component with 'jquery-ui-modules/datetimepicker'.
  • Configured the datetime picker to display both date and time, including hours, minutes, and seconds (though seconds are hidden).

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

The pull request successfully implements the datetime picker functionality for Pay by Link expiration. The changes in the PHP files correctly adapt to the new DATE_TIME_FORMAT and remove the hardcoded 23:59:59 suffix, allowing for more granular control over link validity. The frontend template is also updated to use a datetime picker. However, several unit tests are now outdated and need to be updated to reflect these changes, as they currently assert against old date formats or hardcoded time values.

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud