[ECP-9917] Remove giftcard related merchant risk indicators

[candemiralp]

Description

The plugin recently has implemented giftcard related merchant risk indicator fields to help authentication engine to calculate more accurate risk related to that transaction. However, it has been identified that these fields do not contain the expected values.

This PR removes these fields until a global approach is found instead of adding an internal mapping for ISO 4217 currency codes.

Tested scenarios

• Carte Bancaire
• Carte Bancaire + giftcard
• SVS giftcard

Fixes #3250

[gemini-code-assist]

Summary of Changes

Hello @candemiralp, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request temporarily removes the collection and processing of gift card related merchant risk indicator fields. This decision was made because the fields were not consistently containing the expected values, and a more robust, global approach for handling ISO 4217 currency codes is being developed. The change aims to prevent the transmission of inaccurate data to the authentication engine.

Highlights

• Removed Gift Card Dependencies: The ChargedCurrency and GiftcardPayment helper dependencies have been removed from the MerchantRiskIndicatorDataBuilder class.
• Eliminated Gift Card Risk Indicator Logic: The buildGiftcardRiskIndicatorFields method and its invocation within the build method have been removed from MerchantRiskIndicatorDataBuilder, effectively ceasing the collection of gift card related risk indicators.
• Updated Constructor: The constructor of MerchantRiskIndicatorDataBuilder was updated to no longer require the ChargedCurrency and GiftcardPayment helper objects.
• Removed Corresponding Unit Tests: Unit tests and mock objects specifically related to gift card merchant risk indicators have been removed from MerchantRiskIndicatorDataBuilderTest.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Changelog

• Gateway/Request/MerchantRiskIndicatorDataBuilder.php
  • Removed ChargedCurrency and GiftcardPayment helper dependencies.
  • Removed the buildGiftcardRiskIndicatorFields method.
  • Removed the call to buildGiftcardRiskIndicatorFields from the build method.
• Test/Unit/Gateway/Request/MerchantRiskIndicatorDataBuilderTest.php
  • Removed ChargedCurrency and GiftcardPayment mock objects.
  • Removed test cases testBuildPhysicalGoodsWithGiftcard and testBuildPhysicalGoodsWithGiftcardInvalidData.

Activity

• No specific activity (comments, reviews, etc.) has been recorded for this pull request yet.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request removes the gift card related merchant risk indicators, which is a clean and straightforward change. The dependencies and related logic in MerchantRiskIndicatorDataBuilder have been correctly removed, and the corresponding tests have been updated. I have one suggestion regarding test coverage for the remaining error handling logic.

I am having trouble creating individual review comments. Click here to see my feedback.

Test/Unit/Gateway/Request/MerchantRiskIndicatorDataBuilderTest.php (181-201)

With the removal of this test case, the error handling and logging logic within the try-catch block in MerchantRiskIndicatorDataBuilder is no longer covered by tests. The $adyenLoggerMock is injected but no expectations are set on it in any of the remaining tests.

While the removed gift card logic was the primary source of exceptions, if the try-catch block is being kept for robustness, a test case should exist to validate its behavior.

Please consider adding a test that simulates an exception to ensure the logger is called correctly. If it's determined that no exceptions can be thrown from the try block anymore, the try-catch itself might be redundant and could be removed from MerchantRiskIndicatorDataBuilder for code simplification.

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud