[ECP-9917-v9] Remove giftcard related merchant risk indicators

[candemiralp]

Description

The plugin recently has implemented giftcard related merchant risk indicator fields to help authentication engine to calculate more accurate risk related to that transaction. However, it has been identified that these fields do not contain the expected values.

This PR removes these fields until a global approach is found instead of adding an internal mapping for ISO 4217 currency codes.

Tested scenarios

• Carte Bancaire
• Carte Bancaire + giftcard
• SVS giftcard

[gemini-code-assist]

Summary of Changes

Hello @candemiralp, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses an issue where giftcard-related merchant risk indicator fields were not populating with expected values. To prevent the transmission of inaccurate data to the authentication engine, these fields and their associated logic have been temporarily removed. This change ensures data integrity until a more comprehensive and globally applicable solution for currency code mapping and giftcard risk assessment can be implemented.

Highlights

• Removed Giftcard Risk Indicators: The pull request removes the logic responsible for building and sending giftcard-related merchant risk indicator fields.
• Dependency Cleanup: Unused helper classes, ChargedCurrency and GiftcardPayment, along with CartInterface and AdyenAmountCurrency (in tests), were removed from the MerchantRiskIndicatorDataBuilder and its corresponding test file.
• Test Case Removal: Unit tests specifically covering the building of giftcard risk indicators, including scenarios for valid and invalid data, were removed.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Changelog

• Gateway/Request/MerchantRiskIndicatorDataBuilder.php
  • Removed ChargedCurrency and GiftcardPayment helper class imports.
  • Removed CartInterface import.
  • Removed ChargedCurrency and GiftcardPayment from the constructor parameters and class properties.
  • Removed the call to buildGiftcardRiskIndicatorFields from the build method.
  • Removed the private method buildGiftcardRiskIndicatorFields entirely.
• Test/Unit/Gateway/Request/MerchantRiskIndicatorDataBuilderTest.php
  • Removed ChargedCurrency, GiftcardPayment, and AdyenAmountCurrency class imports.
  • Removed mock object declarations for chargedCurrencyMock and giftcardPaymentHelperMock.
  • Removed instantiation of chargedCurrencyMock and giftcardPaymentHelperMock in the setUp method.
  • Adjusted the constructor call for MerchantRiskIndicatorDataBuilder to reflect the removed dependencies.
  • Removed the testBuildPhysicalGoodsWithGiftcard test method.
  • Removed the testBuildPhysicalGoodsWithGiftcardInvalidData test method.

Activity

• No human activity has been recorded on this pull request yet.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[sonarqubecloud]

Quality Gate failed

Failed conditions
78.1% Coverage on New Code (required ≥ 80%)

See analysis details on SonarQube Cloud

[gemini-code-assist]

Code Review

This pull request removes the functionality for gift card-related merchant risk indicators. The changes are clean and focused, correctly removing the logic from MerchantRiskIndicatorDataBuilder and the associated dependencies. The corresponding unit tests have also been removed, ensuring the test suite remains consistent with the codebase. The changes effectively roll back the feature as described in the pull request description. The implementation is sound, and I have no further suggestions.