Conversation
Summary of ChangesHello @AdyenAutomationBot, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request performs a routine version update for the Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
8e8ebc1 to
b1bb103
Compare
There was a problem hiding this comment.
Code Review
This pull request prepares for the v10.7.2 release by updating the version number in the VERSION and composer.json files. While these changes are correct, a critical update is missing in etc/module.xml. The setup_version attribute is not present in the <module> tag, which is essential for Magento 2's module upgrade process to handle database schema and data migrations. This omission should be addressed to ensure module stability and correct version reporting in the Magento admin.
| "description": "Official Magento2 Plugin to connect to Payment Service Provider Adyen.", | ||
| "type": "magento2-module", | ||
| "version": "10.7.1", | ||
| "version": "10.7.2", |
There was a problem hiding this comment.
While the version is correctly updated in this file, the corresponding module version in etc/module.xml is missing. For Magento 2 modules, the setup_version attribute in the <module> tag of etc/module.xml is essential for handling database schema and data migrations during upgrades. This attribute appears to be missing entirely from the file.
Please add it, for example:
<module name="Adyen_Payment" setup_version="10.7.2">b1bb103 to
6ffdd06
Compare
6ffdd06 to
149ddf5
Compare
|



Merged pull requests to be released:
Full Changelog: v10.7.1...main